Skip to content

chore(common): introduce integrity check for contract licenses#2154

Merged
mergify[bot] merged 3 commits intomainfrom
isaac/168/chore/BSD-3-Clause-Clear-license-check
Mar 26, 2026
Merged

chore(common): introduce integrity check for contract licenses#2154
mergify[bot] merged 3 commits intomainfrom
isaac/168/chore/BSD-3-Clause-Clear-license-check

Conversation

@isaacdecoded
Copy link
Copy Markdown
Contributor

@isaacdecoded isaacdecoded commented Mar 23, 2026

@isaacdecoded isaacdecoded requested review from a team as code owners March 23, 2026 15:20
@cla-bot cla-bot bot added the cla-signed label Mar 23, 2026
@isaacdecoded isaacdecoded force-pushed the isaac/168/chore/BSD-3-Clause-Clear-license-check branch from e94ed48 to eff4b2d Compare March 24, 2026 11:43
zmalatrax
zmalatrax reviewed Mar 24, 2026
View reviewed changes
zmalatrax
zmalatrax reviewed Mar 24, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@zmalatrax zmalatrax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm

Though, is the target only host|gateway-contracts/contracts or all contracts ?
These directories are not checks:

  • host-contracts/lib/, host-contracts/examples/, host-contracts/test/, host-contracts/addresses/, host-contracts/fhevm-foundry/
  • library-solidity/ (lib, examples, tests, config)
  • test-suite/e2e/contracts/
  • coprocessor/fhevm-engine/*/contracts/

Some of them, like host-contracts/lib/cryptography/FhevmECDSA.sol are external deps (copied from OpenZeppelin) ; if we include all these path, we should have an exclusion mechanism for such files (either --exclude or .spdx.ignore file list 🤔

@isaacdecoded
Copy link
Copy Markdown
Contributor Author

isaacdecoded commented Mar 25, 2026

overall lgtm

Though, is the target only host|gateway-contracts/contracts or all contracts ? These directories are not checks:

  • host-contracts/lib/, host-contracts/examples/, host-contracts/test/, host-contracts/addresses/, host-contracts/fhevm-foundry/
  • library-solidity/ (lib, examples, tests, config)
  • test-suite/e2e/contracts/
  • coprocessor/fhevm-engine/*/contracts/

Some of them, like host-contracts/lib/cryptography/FhevmECDSA.sol are external deps (copied from OpenZeppelin) ; if we include all these path, we should have an exclusion mechanism for such files (either --exclude or .spdx.ignore file list 🤔

Good remark, indeed. Just added some of these suggestions in the last commit. Basically, included the host-contracts/lib and the library-solidity contracts. The test-suite, coprocessor, and examples contracts were skipped since they are tests-only code, meaning that they're not intended for production or public deliverables. cc @zmalatrax

@isaacdecoded isaacdecoded requested a review from zmalatrax March 25, 2026 14:43
zmalatrax
zmalatrax approved these changes Mar 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@zmalatrax zmalatrax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@isaacdecoded
Copy link
Copy Markdown
Contributor Author

isaacdecoded commented Mar 26, 2026

@Mergifyio queue

@mergify
Copy link
Copy Markdown

mergify bot commented Mar 26, 2026 •
edited
Loading

Merge Queue Status

This pull request spent 1 hour 48 minutes 25 seconds in the queue, including 9 minutes 48 seconds running CI.

Reason

The merge conditions cannot be satisfied due to failing checks

Hint

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

mergify bot added a commit that referenced this pull request Mar 26, 2026
@mergify
Merge of #2154
4f0f225
This was referenced Mar 26, 2026
Closed
Merged
@isaacdecoded
Copy link
Copy Markdown
Contributor Author

isaacdecoded commented Mar 26, 2026

@Mergifyio queue

@mergify
Copy link
Copy Markdown

mergify bot commented Mar 26, 2026 •
edited
Loading

Merge Queue Status

🛑 Queue command has been cancelled

@mergify mergify bot added the queued label Mar 26, 2026
mergify bot added a commit that referenced this pull request Mar 26, 2026
@mergify
Merge of #2154
48f1295
This was referenced Mar 26, 2026
Closed
Merged
Merged
@mergify mergify bot added merge-queued and removed dequeued labels Mar 26, 2026
@mergify mergify bot mentioned this pull request Mar 26, 2026
Closed
69 tasks
@isaacdecoded
Copy link
Copy Markdown
Contributor Author

isaacdecoded commented Mar 26, 2026

@Mergifyio queue

@mergify
Copy link
Copy Markdown

mergify bot commented Mar 26, 2026 •
edited
Loading

Merge Queue Status

  • 🟠 Waiting for queue conditions
  • ⏳ Enter queue
  • ⏳ Run checks
  • ⏳ Merge
Required conditions to enter a queue
  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of [📌 queue -> configuration change requirements]:
    • -mergify-configuration-changed
    • check-success = Configuration changed
  • any of [🔀 queue conditions]:
    • all of [📌 queue conditions of queue rule main]:
      • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • base = main
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • label!=do-not-merge
      • any of [🛡 GitHub branch protection]:
        • check-success = common-pull-request/lint (bpr)
        • check-neutral = common-pull-request/lint (bpr)
        • check-skipped = common-pull-request/lint (bpr)
      • any of [🛡 GitHub branch protection]:
        • check-skipped = coprocessor-cargo-test/cargo-tests (bpr)
        • check-neutral = coprocessor-cargo-test/cargo-tests (bpr)
        • check-success = coprocessor-cargo-test/cargo-tests (bpr)
      • any of [🛡 GitHub branch protection]:
        • check-skipped = coprocessor-dependency-analysis/dependencies-check (bpr)
        • check-neutral = coprocessor-dependency-analysis/dependencies-check (bpr)
        • check-success = coprocessor-dependency-analysis/dependencies-check (bpr)
      • any of [🛡 GitHub branch protection]:
        • check-success = gateway-contracts-deployment-tests/sc-deploy (bpr)
        • check-neutral = gateway-contracts-deployment-tests/sc-deploy (bpr)
        • check-skipped = gateway-contracts-deployment-tests/sc-deploy (bpr)
      • any of [🛡 GitHub branch protection]:
        • check-skipped = kms-connector-tests/test-connector (bpr)
        • check-neutral = kms-connector-tests/test-connector (bpr)
        • check-success = kms-connector-tests/test-connector (bpr)

@mergify
Copy link
Copy Markdown

mergify bot commented Mar 26, 2026 •
edited
Loading

Merge Queue Status

  • ✅ Entered queue — 2026-03-26 14:50 UTC · Rule: main
  • 🚫 Left the queue — 2026-03-26 15:00 UTC · at fae55f3c1c678454a65ac55c8256ddb7019b6f07

This pull request spent 10 minutes 15 seconds in the queue, with no time running CI.

Reason

Pull request #2154 has been dequeued by a dequeue command

Hint

If you want to requeue this pull request, you can post a @mergifyio queue comment.

@isaacdecoded
Copy link
Copy Markdown
Contributor Author

isaacdecoded commented Mar 26, 2026

@Mergifyio dequeue

@isaacdecoded
Copy link
Copy Markdown
Contributor Author

isaacdecoded commented Mar 26, 2026

@Mergifyio refresh

@mergify
Copy link
Copy Markdown

mergify bot commented Mar 26, 2026

refresh

✅ Pull request refreshed

@isaacdecoded
Copy link
Copy Markdown
Contributor Author

isaacdecoded commented Mar 26, 2026

@Mergifyio queue

@mergify
Copy link
Copy Markdown

mergify bot commented Mar 26, 2026 •
edited
Loading

Merge Queue Status

This pull request spent 2 hours 11 minutes 17 seconds in the queue, including 57 minutes 44 seconds running CI.

Required conditions to merge

mergify bot added a commit that referenced this pull request Mar 26, 2026
@mergify
Merge of #2154
87be6fb
This was referenced Mar 26, 2026
Closed
Merged
mergify bot added a commit that referenced this pull request Mar 26, 2026
@mergify
Merge of #2154
b7bb514
@mergify mergify bot mentioned this pull request Mar 26, 2026
Closed
51 tasks
mergify bot added a commit that referenced this pull request Mar 26, 2026
@mergify
Merge of #2154
1ab0cea
@mergify mergify bot mentioned this pull request Mar 26, 2026
Closed
76 tasks
@mergify mergify bot removed the merge-queued label Mar 26, 2026
@mergify mergify bot merged commit 89d38f8 into main Mar 26, 2026
66 of 67 checks passed
@mergify mergify bot deleted the isaac/168/chore/BSD-3-Clause-Clear-license-check branch March 26, 2026 17:21
@mergify mergify bot removed the queued label Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zmalatrax zmalatrax zmalatrax approved these changes

Assignees

No one assigned

Labels

cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@isaacdecoded @zmalatrax