Skip to content

chore(common): extend getRequiredEnvVar method to check empty values#2156

Merged
mergify[bot] merged 3 commits intomainfrom
isaac/chore/157/check-deployment-env-vars-value
Mar 27, 2026
Merged

chore(common): extend getRequiredEnvVar method to check empty values#2156
mergify[bot] merged 3 commits intomainfrom
isaac/chore/157/check-deployment-env-vars-value

Conversation

@isaacdecoded
Copy link
Copy Markdown
Contributor

@isaacdecoded isaacdecoded commented Mar 23, 2026

@isaacdecoded isaacdecoded requested a review from a team as a code owner March 23, 2026 15:38
@cla-bot cla-bot bot added the cla-signed label Mar 23, 2026
@isaacdecoded isaacdecoded force-pushed the isaac/chore/157/check-deployment-env-vars-value branch from c8b49b1 to ac6fed9 Compare March 24, 2026 11:42
zmalatrax
zmalatrax reviewed Mar 24, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@zmalatrax zmalatrax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

library-solidity/tasks/utils/loadVariables.ts has an identical getRequiredEnvVar function that was not updated. It still has the old behavior (no empty check) and even retains the comment
// We only check if the variable is set, not if it's empty.

This means deployments using the library-solidity tasks still silently accept empty env vars.

library-solidity should be updated as well, or not used?

Otherwise lgtm

@isaacdecoded isaacdecoded requested a review from zmalatrax March 25, 2026 10:53
zmalatrax
zmalatrax previously approved these changes Mar 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@zmalatrax zmalatrax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@isaacdecoded
Copy link
Copy Markdown
Contributor Author

isaacdecoded commented Mar 26, 2026

@Mergifyio queue

@mergify
Copy link
Copy Markdown

mergify bot commented Mar 26, 2026 •
edited
Loading

Merge Queue Status

  • ✅ Entered queue — 2026-03-26 10:58 UTC · Rule: main
  • 🚫 Left the queue — 2026-03-26 10:59 UTC · at 18c8190d1a9bad555e80e83142b560901797b65c

This pull request spent 1 minute 37 seconds in the queue, with no time running CI.

Reason

The pull request conflicts with pull requests ahead in queue: #2157, #2163, #2158

Hint

There is nothing you can do for now. If the pull request ahead in the queue is merged, this pull request will become conflicting and you'll have to update it.
If the pull request ahead is not merged, you can requeue this pull request with a @mergifyio queue comment.

@isaacdecoded isaacdecoded force-pushed the isaac/chore/157/check-deployment-env-vars-value branch from 18c8190 to 4555946 Compare March 26, 2026 12:34
@mergify mergify bot removed the dequeued label Mar 26, 2026
@isaacdecoded isaacdecoded requested a review from zmalatrax March 26, 2026 12:52
zmalatrax
zmalatrax previously approved these changes Mar 26, 2026
View reviewed changes
@isaacdecoded
Copy link
Copy Markdown
Contributor Author

isaacdecoded commented Mar 26, 2026

@Mergifyio queue

@mergify
Copy link
Copy Markdown

mergify bot commented Mar 26, 2026 •
edited
Loading

Merge Queue Status

🛑 Queue command has been cancelled

@mergify mergify bot added the queued label Mar 26, 2026
mergify bot added a commit that referenced this pull request Mar 26, 2026
@mergify
Merge of #2156
cce4c51
@mergify mergify bot mentioned this pull request Mar 26, 2026
Closed
69 tasks
@mergify mergify bot added the merge-queued label Mar 26, 2026
This was referenced Mar 26, 2026
Merged
Merged
@isaacdecoded isaacdecoded force-pushed the isaac/chore/157/check-deployment-env-vars-value branch from 4555946 to 90a12a3 Compare March 26, 2026 14:44
@isaacdecoded
Copy link
Copy Markdown
Contributor Author

isaacdecoded commented Mar 26, 2026

@Mergifyio queue

@mergify mergify bot added the queued label Mar 27, 2026
mergify bot added a commit that referenced this pull request Mar 27, 2026
@mergify
Merge of #2156
ffe80f4
This was referenced Mar 27, 2026
Closed
Merged
mergify bot added a commit that referenced this pull request Mar 27, 2026
@mergify
Merge of #2156
cbe2610
@mergify mergify bot mentioned this pull request Mar 27, 2026
Closed
51 tasks
@mergify mergify bot added dequeued and removed queued labels Mar 27, 2026
@isaacdecoded isaacdecoded force-pushed the isaac/chore/157/check-deployment-env-vars-value branch from 08358a5 to 8d01ffa Compare March 27, 2026 11:44
@isaacdecoded isaacdecoded requested a review from a team as a code owner March 27, 2026 11:44
@isaacdecoded isaacdecoded requested a review from zmalatrax March 27, 2026 11:44
@mergify mergify bot removed the dequeued label Mar 27, 2026
@isaacdecoded
Copy link
Copy Markdown
Contributor Author

isaacdecoded commented Mar 27, 2026

@Mergifyio refresh

@mergify
Copy link
Copy Markdown

mergify bot commented Mar 27, 2026

refresh

✅ Pull request refreshed

@isaacdecoded
Copy link
Copy Markdown
Contributor Author

isaacdecoded commented Mar 27, 2026

@Mergifyio queue

@mergify
Copy link
Copy Markdown

mergify bot commented Mar 27, 2026 •
edited
Loading

Merge Queue Status

This pull request spent 2 hours 16 minutes 5 seconds in the queue, including 1 hour 14 minutes 55 seconds running CI.

Required conditions to merge

mergify bot added a commit that referenced this pull request Mar 27, 2026
@mergify
Merge of #2156
be28485
This was referenced Mar 27, 2026
Closed
Merged
@mergify mergify bot merged commit 982d670 into main Mar 27, 2026
75 of 76 checks passed
@mergify mergify bot deleted the isaac/chore/157/check-deployment-env-vars-value branch March 27, 2026 14:38
@mergify mergify bot removed the queued label Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zmalatrax zmalatrax zmalatrax approved these changes

Assignees

No one assigned

Labels

cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@isaacdecoded @zmalatrax