tests: bsim: Bluetooth: Fail on advertising start error #97479
+11
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvinayak
force-pushed
the
github_test_ll_conn_fix
branch
from
a3fc8f6 to
1a1db68
Compare
zephyrbot
added
area: Bluetooth
area: Tests
zephyrbot
requested review from
Tronil,
carlescufi,
erbr-ot,
nashif,
ppryga,
thoh-ot and
wopu-ot
jhedberg
reviewed
Oct 14, 2025
| err = bt_le_adv_start(BT_LE_ADV_CONN_FAST_1, ad, ARRAY_SIZE(ad), NULL, 0); | ||
| err = start_advertising(); | ||
| if (err) { | ||
| FAIL("Advertising failed to start (err %d)\n", err); |
There was a problem hiding this comment.
Wont this cause log string duplication with the printk() that start_advertising() has internally for the error case?
There was a problem hiding this comment.
Good catch. I will remove the printk there, as we need FAIL that sets bst_result for bsim verdict.
Add back test failure that was missed when fixing double and redundant advertising start in commit 7a672c0 ("Bluetooth: tests: bsim: Fix double advertising in test_connect2"). Also, relates to commit 8cfad44 ("Bluetooth: Deprecate adv auto-resume"). Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
cvinayak
force-pushed
the
github_test_ll_conn_fix
branch
from
1a1db68 to
8f32267
Compare
cvinayak
changed the title
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add back test failure that was missed when fixing double
and redundant advertising start in
commit 7a672c0 ("Bluetooth: tests: bsim: Fix double
advertising in test_connect2").
Also, relates to commit 8cfad44 ("Bluetooth: Deprecate
adv auto-resume").