Skip to content

tests: bsim: Bluetooth: Fail on advertising start error #97479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −5
Open

tests: bsim: Bluetooth: Fail on advertising start error #97479

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions tests/bsim/bluetooth/ll/conn/src/test_connect2.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,16 +127,20 @@ static int start_advertising(void)
int err;

err = bt_le_adv_start(BT_LE_ADV_CONN_FAST_1, ad, ARRAY_SIZE(ad), NULL, 0);
if (err) {
printk("Advertising failed to start (err %d)\n", err);
}

return err;
}

static void recycled(void)
{
start_advertising();
int err;

err = start_advertising();
if (err) {
FAIL("Advertising failed to restart (err %d)\n", err);
} else {
printk("Advertising successfully restarted\n");
}
}

static struct bt_conn_cb conn_callbacks = {
Expand All @@ -152,7 +156,9 @@ static void bt_ready(void)
printk("Peripheral Bluetooth initialized\n");

err = start_advertising();
if (!err) {
if (err) {
FAIL("Advertising failed to start (err %d)\n", err);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wont this cause log string duplication with the printk() that start_advertising() has internally for the error case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I will remove the printk there, as we need FAIL that sets bst_result for bsim verdict.

} else {
printk("Advertising successfully started\n");
}
}
Expand Down