Clone InitializationData in Java Communicator constructor #4615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the Java Communicator constructor to clone the InitializationData parameter before passing it to the internal initialize method, preventing potential external modifications to the initialization data after communicator creation.
Key Changes:
- The InitializationData object is now cloned before being passed to
_instance.initialize()to ensure immutability of the communicator's configuration.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| public Communicator(InitializationData initData) { | ||
| _instance = new Instance(); | ||
| _instance.initialize(this, initData); | ||
| _instance.initialize(this, initData.clone()); |
There was a problem hiding this comment.
Potential NullPointerException if initData is null. Consider adding a null check before calling clone(), or handle the null case explicitly (e.g., passing null or creating a default InitializationData instance).
Suggested change
| _instance.initialize(this, initData.clone()); | |
| _instance.initialize(this, initData != null ? initData.clone() : new InitializationData()); |
bernardnormier
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.