Skip to content

Clone InitializationData in Java Communicator constructor #4615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2025
Merged

Clone InitializationData in Java Communicator constructor #4615

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion java/src/com.zeroc.ice/src/main/java/com/zeroc/Ice/Communicator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public final class Communicator implements AutoCloseable {
*/
public Communicator(InitializationData initData) {
_instance = new Instance();
_instance.initialize(this, initData);
_instance.initialize(this, initData.clone());
Copy link

Copilot AI Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential NullPointerException if initData is null. Consider adding a null check before calling clone(), or handle the null case explicitly (e.g., passing null or creating a default InitializationData instance).

Suggested change
_instance.initialize(this, initData.clone());
_instance.initialize(this, initData != null ? initData.clone() : new InitializationData());

Copilot uses AI. Check for mistakes.

try {
_instance.finishSetup(this);
Expand Down