-
Notifications
You must be signed in to change notification settings - Fork 797
Add manufacturer in signature to GLEDOPTO SoposhGU10 quirk #2721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2721 +/- ##
=======================================
Coverage 87.90% 87.91%
=======================================
Files 300 300
Lines 9222 9227 +5
=======================================
+ Hits 8107 8112 +5
Misses 1115 1115 ☔ View full report in Codecov by Sentry. |
ebdc03b
to
cc43b28
Compare
The model should also be added: |
35fac10
to
49350f7
Compare
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
Proposed change
Adds the manufacturer name to the signature in GLEDOPTO SoposhGU10 quirk.
This PR is the first part to remove devices with exceptions from:
Additional information
We don't have the original signature and it's also not in the original PR.
There are multiple model names in Z2M's code that could be possible for this.
But we might still miss some devices by using
MODELS_INFO
, thus this PR usesMANUFACTURER
for now.This narrows it down a bit at least, but ideally, we should get all model names that this quirk needs to be applied to.
There's some weirdness going on with the other GLEDOPTO quirk that was added in the linked PR above.
According to Z2M, it's an RGB-CCT device, yet the quirk removes all clusters except the one with the
COLOR_DIMMABLE_LIGHT
type:zha-device-handlers/zhaquirks/gledopto/gls007z.py
Line 84 in 22a1ac5
I guess the
Color
cluster could expose other color modes, but the quirk should still change theDEVICE_TYPE
in that case.Checklist
pre-commit
checks pass / the code has been formatted using Black