Skip to content

Add manufacturer in signature to GLEDOPTO SoposhGU10 quirk #2721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

TheJulianJES
Copy link
Collaborator

Proposed change

Adds the manufacturer name to the signature in GLEDOPTO SoposhGU10 quirk.

This PR is the first part to remove devices with exceptions from:

Additional information

We don't have the original signature and it's also not in the original PR.
There are multiple model names in Z2M's code that could be possible for this.

But we might still miss some devices by using MODELS_INFO, thus this PR uses MANUFACTURER for now.
This narrows it down a bit at least, but ideally, we should get all model names that this quirk needs to be applied to.


There's some weirdness going on with the other GLEDOPTO quirk that was added in the linked PR above.
According to Z2M, it's an RGB-CCT device, yet the quirk removes all clusters except the one with the COLOR_DIMMABLE_LIGHT type:

DEVICE_TYPE: zha.DeviceType.COLOR_DIMMABLE_LIGHT,

I guess the Color cluster could expose other color modes, but the quirk should still change the DEVICE_TYPE in that case.

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

@TheJulianJES TheJulianJES added the code quality Improvement to code quality label Nov 7, 2023
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.91%. Comparing base (9ccb69a) to head (35fac10).
Report is 6 commits behind head on dev.

❗ Current head 35fac10 differs from pull request most recent head 49350f7. Consider uploading reports for the commit 49350f7 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2721   +/-   ##
=======================================
  Coverage   87.90%   87.91%           
=======================================
  Files         300      300           
  Lines        9222     9227    +5     
=======================================
+ Hits         8107     8112    +5     
  Misses       1115     1115           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheJulianJES
Copy link
Collaborator Author

@TheJulianJES TheJulianJES force-pushed the tjj/clean_add_model_info_1 branch 2 times, most recently from 35fac10 to 49350f7 Compare April 11, 2024 01:19
Copy link

github-actions bot commented Oct 8, 2024

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale Issue is inactivate and might get closed soon label Oct 8, 2024
@TheJulianJES TheJulianJES removed the stale Issue is inactivate and might get closed soon label Oct 8, 2024
Copy link

github-actions bot commented Apr 7, 2025

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale Issue is inactivate and might get closed soon label Apr 7, 2025
@TheJulianJES TheJulianJES removed the stale Issue is inactivate and might get closed soon label Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Improvement to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant