-
Notifications
You must be signed in to change notification settings - Fork 797
Add Third Reality watering kit options #3926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3926 +/- ##
==========================================
+ Coverage 91.00% 91.12% +0.11%
==========================================
Files 328 334 +6
Lines 10656 10787 +131
==========================================
+ Hits 9698 9830 +132
+ Misses 958 957 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll push the suggested changes myself.
Please keep in mind the correct capitalization needed for HA entities for future PRs:
Due to HA naming conventions, only the first letter of an entity name should be upper-case (except for abbreviations). So it should be "Water duration" instead of "Water Duration", for example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, please use more descriptive PR titles for future PRs.
Examples for this PR:
- "Add Third Reality watering kit options"
- "Add Third Reality watering kit entities"
- "Add Third Reality watering kit configuration"
OK |
OK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good now, thanks!
Thank you, too! |
It was mentioned that the device has an IasZone cluster. What does that do? Report low battery? @hwzolin ZHA doesn't support the low battery bit for the IasZone cluster, so if that's the only function, we can disable discovery of default entities for the IasZone cluster by adding this: .prevent_default_entity_creation(endpoint_id=1, cluster_id=IasZone.cluster_id) An alternative is to "remove" the cluster entirely (from ZHA's point of view) via: .removes(IasZone.cluster_id) |
Hello, the setting is like this: our watering kit, in the process of watering, if it detects that there is no water, then it will trigger an alarm of no water. This alert also needs to be reflected in the ZHA. |
Ah ok, thanks! That'll already work as expected then. |
@hwzolin is there reporting on the custom cluster (0xfff2)? How do you know in the app the user has changed the device values? See #3983 |
@mguaylam Hello and thanks for your feedback. In order to reduce battery drain, the watering duration has been changed to 1 - 1800 seconds, depending on the settings of our new version of the device. @TheJulianJES However, the user mentioned the issue about the report after the device modification is completed. I'm also curious about what the ZHA platform will do. Is it possible to display the value of the change in real time in the log on the right side of the page? The following image is a screenshot of the water duration command and the response of the device: |
To update the entity in Home Assistant, you can send a "Zigbee attribute report" for that attribute in the device firmware.
Replied in the issue. I think I managed to reproduce this, but it's mostly only a visual glitch, from what I can tell. The entity should still work fine elsewhere, from what I can see. So, I still recommend setting correct units and hope this can be fixed in Home Assistant at some point. |
OK, thanks for taking the time to look into this. Although the problem is not solved, you cleared up my confusion. |
It works on the OnOff cluster : But not on your custom cluster (0xfff2), I can't see any response from the device. You need to do a ZigBee attribute report. IMG_5027.MOV |
@mguaylam Hello, for your first question. Yes, that's what we're set up right now. You can check the latest electronic version of the user manual on our official website (link is: https://tr-common-us-prod.s3.us-west-1.amazonaws.com/product/manual/SmartWateringKit.pdf) And your second question, I've already fed back to our developers. We will optimize this in future firmware releases. Thank you for your attention, I believe that your valuable suggestions will help us make our products better. |
Proposed change
Additional information
Checklist
pre-commit
checks pass / the code has been formatted using Black