-
Notifications
You must be signed in to change notification settings - Fork 796
Change min value, max value, step and try to implement reporting for ThirdReality Watering kit #3983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3983 +/- ##
==========================================
+ Coverage 91.13% 91.18% +0.04%
==========================================
Files 334 334
Lines 10790 10862 +72
==========================================
+ Hits 9833 9904 +71
- Misses 957 958 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hey there @hwzolin, once you fix the reporting for |
We should hold back with the reporting until it's implemented in the firmware.
|
@mguaylam Ok, I'll let you know as soon as we develop a new firmware that supports the feature. |
Proposed change
Fix the values of the watering time and try to implement reporting.
Additional information
Fixes #3926.
Checklist
pre-commit
checks pass / the code has been formatted using Black