Skip to content

Change min value, max value, step and try to implement reporting for ThirdReality Watering kit #3983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

mguaylam
Copy link
Contributor

@mguaylam mguaylam commented Mar 26, 2025

Proposed change

Fix the values of the watering time and try to implement reporting.

Additional information

Fixes #3926.

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.18%. Comparing base (8ca9bdc) to head (2008427).
Report is 14 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3983      +/-   ##
==========================================
+ Coverage   91.13%   91.18%   +0.04%     
==========================================
  Files         334      334              
  Lines       10790    10862      +72     
==========================================
+ Hits         9833     9904      +71     
- Misses        957      958       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mguaylam
Copy link
Contributor Author

Hey there @hwzolin, once you fix the reporting for 0xFFF2 in the firmware, can you let us know so we can merge this?
@TheJulianJES should we wait for ThirdReality to implement it? The number min and increment needed to be fixed anyway.

@TheJulianJES
Copy link
Collaborator

TheJulianJES commented Mar 31, 2025

We should hold back with the reporting until it's implemented in the firmware.
I guess min and increment can be changed though.

increment only really influences this if the number entity mode is in SLIDER mode, which I believe most quirks v2 entities are currently due to zigpy/zha#364.
If a number entity is in BOX mode, I don't think that increment does anything. A service/action call can always be used to set a number manually otherwise, even if in SLIDER mode.

@hwzolin
Copy link
Contributor

hwzolin commented Apr 1, 2025

We should hold back with the reporting until it's implemented in the firmware. I guess min and increment can be changed though.

increment only really influences this if the number entity mode is in SLIDER mode, which I believe most quirks v2 entities are currently due to zigpy/zha#364. If a number entity is in BOX mode, I don't think that increment does anything. A service/action call can always be used to set a number manually otherwise, even if in SLIDER mode.

@mguaylam Ok, I'll let you know as soon as we develop a new firmware that supports the feature.

@TheJulianJES TheJulianJES added the waiting for changes Waiting for changes to the PR label Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for changes Waiting for changes to the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants