[WIP] get rid of the is_cosine field#1496
[WIP] get rid of the is_cosine field#1496alexanderguzhva wants to merge 2 commits intozilliztech:mainfrom
is_cosine field#1496Conversation
Signed-off-by: Alexandr Guzhva <alexanderguzhva@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexanderguzhva The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@alexanderguzhva 🔍 Important: PR Classification Needed! For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:
For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”. Thanks for your efforts and contribution to the community!. |
Signed-off-by: Alexandr Guzhva <alexanderguzhva@gmail.com>
|
issue: #1501 |
|
issue: #1501 |
This is the change, targeted at lowering the burden of the
faiss::cppcontrib::knowhere.The following the most important things are implemented:
is_cosinefield1 / ||x||formatknowhere's custom components forFAISS