Skip to content

[WIP] get rid of the is_cosine field#1496

Open
alexanderguzhva wants to merge 2 commits intozilliztech:mainfrom
alexanderguzhva:more_fix_fork
Open

[WIP] get rid of the is_cosine field#1496
alexanderguzhva wants to merge 2 commits intozilliztech:mainfrom
alexanderguzhva:more_fix_fork

Conversation

@alexanderguzhva
Copy link
Collaborator

@alexanderguzhva alexanderguzhva commented Mar 10, 2026

This is the change, targeted at lowering the burden of the faiss::cppcontrib::knowhere.

The following the most important things are implemented:

  • Remove the is_cosine field
    • All L2 norms are now stored in the memory in the 1 / ||x|| format
  • Simplify the hierarchy of knowhere's custom components for FAISS

Signed-off-by: Alexandr Guzhva <alexanderguzhva@gmail.com>
@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexanderguzhva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify
Copy link

mergify bot commented Mar 10, 2026

@alexanderguzhva 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

Signed-off-by: Alexandr Guzhva <alexanderguzhva@gmail.com>
@alexanderguzhva
Copy link
Collaborator Author

alexanderguzhva commented Mar 13, 2026

issue: #1501
/kind improvement

@alexanderguzhva
Copy link
Collaborator Author

issue: #1501
/kind improvement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants