Skip to content

upgrade faiss to 1.14.1#1497

Merged
sre-ci-robot merged 3 commits into
zilliztech:mainfrom
alexanderguzhva:more_fix_fork_2
Mar 25, 2026
Merged

upgrade faiss to 1.14.1#1497
sre-ci-robot merged 3 commits into
zilliztech:mainfrom
alexanderguzhva:more_fix_fork_2

Conversation

@alexanderguzhva
Copy link
Copy Markdown
Collaborator

@alexanderguzhva alexanderguzhva commented Mar 12, 2026

  • Upgrade faiss to 1.14.1+, commit so far is e5114c2368073d00316a866baa33e6595df3c396 (Mar 20 2026)
  • deprecate enable_bf16_patch logic
  • get rid of the forked IndexPQ, ProductQuantizer
  • get rid of forked IVFFastScan-related facilities (such as pq4)
  • get rid of the forked simblib
  • get rid of the forked IndexBinaryHNSW
  • get rid of the forked partitioning_avx2
  • in process of merging dynamic dispatching mechanisms
  • modernize a forked IVFFastScan indices to match the baseline
  • upgrade the libfaiss.cmake file

Contains #1496
Contains facebookresearch/faiss#4894
Contains facebookresearch/faiss#4926 , which also fixes some problems with the pqfastscan filtering code

@mergify
Copy link
Copy Markdown

mergify Bot commented Mar 12, 2026

@alexanderguzhva 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

@alexanderguzhva
Copy link
Copy Markdown
Collaborator Author

/kind improvement
issue: #1501

@alexanderguzhva
Copy link
Copy Markdown
Collaborator Author

rebased on top of master

Signed-off-by: Alexandr Guzhva <alexanderguzhva@gmail.com>
Signed-off-by: Alexandr Guzhva <alexanderguzhva@gmail.com>
Signed-off-by: Alexandr Guzhva <alexanderguzhva@gmail.com>
Copy link
Copy Markdown
Collaborator

@foxspy foxspy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexanderguzhva, foxspy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [alexanderguzhva,foxspy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants