Skip to content

fix(codex): preserve explicit memory directory in installer#561

Open
dommonkhouse wants to merge 1 commit into
zilliztech:mainfrom
dommonkhouse:fix/codex-installer-preserve-memsearch-dir
Open

fix(codex): preserve explicit memory directory in installer#561
dommonkhouse wants to merge 1 commit into
zilliztech:mainfrom
dommonkhouse:fix/codex-installer-preserve-memsearch-dir

Conversation

@dommonkhouse

Copy link
Copy Markdown

Summary

  • preserve an explicitly supplied MEMSEARCH_DIR in installed Codex hook commands
  • keep the default installer behaviour unchanged when MEMSEARCH_DIR is not set
  • quote the preserved path safely for hook command execution

Verification

  • bash -n plugins/codex/scripts/install.sh
  • installer smoke test with MEMSEARCH_DIR unset writes normal hook commands
  • installer smoke test with MEMSEARCH_DIR set writes MEMSEARCH_DIR-prefixed hook commands
  • git diff --check
  • scanned diff additions for user-specific local paths

@dommonkhouse

Copy link
Copy Markdown
Author

Ready for maintainer review and merge. I verified this PR is non-draft, mergeable, and has no configured checks reporting failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant