Skip to content

fix(codex): preserve explicit memory directory in installer #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dommonkhouse wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(codex): preserve explicit memory directory in installer #561

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions plugins/codex/scripts/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,16 +67,19 @@ PY
install_or_update_hooks_file() {
local hooks_file="$1"
local install_dir="$2"
local memsearch_dir="${3:-}"

python3 - "$hooks_file" "$install_dir" <<'PY'
python3 - "$hooks_file" "$install_dir" "$memsearch_dir" <<'PY'
from pathlib import Path
import json
import math
import os
import shlex
import sys

hooks_file = Path(sys.argv[1])
install_dir = sys.argv[2]
memsearch_dir = sys.argv[3]

spec = {
"SessionStart": {"script": "session-start.sh", "timeout": 30},
Expand Down Expand Up @@ -140,6 +143,13 @@ def strip_old_memsearch(entries, script_name):
data = load_existing()
hooks = data.setdefault("hooks", {})

def hook_command(script_name):
command = f"bash {install_dir}/hooks/{script_name}"
if memsearch_dir:
return f"MEMSEARCH_DIR={shlex.quote(memsearch_dir)} {command}"
return command


for event, details in spec.items():
script = details["script"]
cleaned = strip_old_memsearch(hooks.get(event, []), script)
Expand All @@ -149,7 +159,7 @@ for event, details in spec.items():
"hooks": [
{
"type": "command",
"command": f"bash {install_dir}/hooks/{script}",
"command": hook_command(script),
"timeout": details["timeout"],
}
],
Expand Down Expand Up @@ -222,7 +232,7 @@ if [ -f "$HOOKS_FILE" ]; then
echo " ⚠ Existing hooks.json found — backing up to hooks.json.bak"
cp "$HOOKS_FILE" "${HOOKS_FILE}.bak"
fi
install_or_update_hooks_file "$HOOKS_FILE" "$INSTALL_DIR"
install_or_update_hooks_file "$HOOKS_FILE" "$INSTALL_DIR" "${MEMSEARCH_DIR:-}"
echo " ✓ Installed memsearch hooks in $HOOKS_FILE"

# --- 5. Enable hooks feature flag ---
Expand Down