-
Notifications
You must be signed in to change notification settings - Fork 3
Remove node-binding, enhance keyring-util, create github action #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…file to github action Signed-off-by: MarkAckert <[email protected]>
Signed-off-by: MarkAckert <[email protected]>
Signed-off-by: MarkAckert <[email protected]>
Signed-off-by: MarkAckert <[email protected]>
Signed-off-by: MarkAckert <[email protected]>
Signed-off-by: MarkAckert <[email protected]>
Signed-off-by: MarkAckert <[email protected]>
Signed-off-by: MarkAckert <[email protected]>
Signed-off-by: MarkAckert <[email protected]>
Signed-off-by: MarkAckert <[email protected]>
Signed-off-by: Martin Zeithaml <[email protected]>
| @@ -0,0 +1,9 @@ | |||
| --- | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we do two things here?
- Change the extension to
yamlto be consistent with other Zowe components - Add the
buildsection? We can do it as another PR, I think this is usually made by some workflow:
...
build:
branch: "master"
number: "123"
commitHash: "12345...."
timestamp: 1746717018543
This might be handy in the future for various tasks, when the specific commit is needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the extension, and the build block should be left to another PR. I checked our action libraries and I didn't see any common code we could re-use, so we'll need to create it. It looked like the existing implementation is very specific to zlux.
Signed-off-by: Martin Zeithaml <[email protected]>
Signed-off-by: MarkAckert <[email protected]>
Signed-off-by: MarkAckert <[email protected]>
Signed-off-by: MarkAckert <[email protected]>
This PR is part of the work to remove Node.JS as a dependency from
zwecompletely as tracked here: zowe/zowe-install-packaging#4307 .Tests:
happy pathtests work. This matches prior behavior.zwePR are working as expected.migrate for kubernetespulls certificates out of the keyring and loads them into the Java keystore without an error.This PR:
xlclangto build, upgradedarchandtargetparameters.keyring-utilto the forefront as the utility invoked byzwe. Enhancements include:argpwould work better longer term.LISTRINGfunction tokeyring-util. This was limited to the node-binding before and can now be invoked directly.EXPORTnow exports private keys from a keyring in PKCS12 rather than PEM. This was the sore point for integration withzwe, which loads the exported private key into a Java keystore.keytooldid not accept PEM private keys, andopensslwas not available to convert the PEM to another support format. Thencertutility previously did this conversion, but with GSK APIs, we can export directly to a password-protected p12 binary. The export format could be customized via command-line argument, but for now, private keys are always p12 and public certs are alwayscerformatted.GSKwhere available ofR_datalibAPIs, however,GSKAPIs have limitations when compared toR_datalib. For example, the GSK APIs don't return complete certificate/keyring metadata (status, usage, trust), soLISTRINGcontinues usingR_datalib.