- 
                Notifications
    You must be signed in to change notification settings 
- Fork 54
Node Removal Tasks - v3.x #4307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v3.x/staging
Are you sure you want to change the base?
Conversation
| build 7570 FAILED. | 
| build 7571 FAILED. | 
| build 7572 FAILED. | 
| build 7605 FAILED. | 
| build 7609 FAILED. | 
| build 7615 FAILED. | 
| build 7677 FAILED. | 
| build 7698 FAILED. | 
| build 7699 FAILED. | 
| build 7700 FAILED. | 
| build 7701 FAILED. | 
| build 7702 FAILED. | 
Signed-off-by: MarkAckert <[email protected]>
… is unset and app-server is disabled, zOSMF connectivity check always runs Signed-off-by: MarkAckert <[email protected]>
Signed-off-by: MarkAckert <[email protected]>
Signed-off-by: MarkAckert <[email protected]>
Signed-off-by: MarkAckert <[email protected]>
Signed-off-by: MarkAckert <[email protected]>
Signed-off-by: MarkAckert <[email protected]>
Signed-off-by: MarkAckert <[email protected]>
Signed-off-by: Martin Zeithaml <[email protected]>
Addressing other node.js removal tasks as described in #3543. This PR is built on the JCL Init refactor to take advantage of improvements there and the zwe integration test framework.
Requires these 2 PRs to be merged:
As far as I know the below list is all remaining work to address node.js
Complete:
read_yamltoread_yaml_configmgr. Note: later changed so all*_zowe_yaml_configmgrvariants are instead*_zowe_yaml, replacing the old code paths completely.*_zowe_yamlfunctions injson.shto*_zowe_yaml_configmgrvariants.convertandto-env) with configmgr variantskeyring-utilityzowe-install-packaging-toolsno longer a binary dependency.org.zopencommunity.curlintroduced as a binary dependency.require_node.curlandyqtransparently for container environments - no reliance on configmgr code.curlis always available.In progress:
To do:
Changed Behaviors:
zwe migrate for kubernetesoutputs thezowe.yaml |block in the k8s ConfigMap without comments. In my mind, this is acceptable - users should not be extensively modifying this ConfigMap directly.zwe's use cases. notably, the command syntax has changed and keyring private keys are output in.p12format. see: Remove node-binding, enhance keyring-util, create github action keyring-utilities#13config.ts:generateInstanceEnvFromYamlConfigmethod was updated so environment variables with spaces are surrounded by quotes.some_spaced_field=some spaced valuesome_spaced_field="some spaced value"components.tsconfigmgr library was modified to lazily load config./tmp/zweenv-yyyyappear in the console outputcomponents.tsload would always validate against schema and fail the update command, preventing the change that would fix the YAML.config.tsfile was also modified to lazily load config (it checks forZWE_CLI_PARAMETER_CONFIGenv).std.out.printfanyway.Other:
zwe install- noted as a medium priority in the issue, this looks complete betweenread_yaml_configmgrupdates and zwe install in JCL #4282