-
-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display of starred and unstarred messages enhanced #1147
base: main
Are you sure you want to change the base?
Conversation
Hello @Dishti-Oberai, it seems like you have referenced #171 in your pull request description, but you have not referenced them in your commit message description(s). When you reference an issue in a commit message, it automatically closes the corresponding issue when the commit is merged. Please run An example of a correctly-formatted commit:
Thank you for your contributions to Zulip! |
0b3029a
to
423d29d
Compare
423d29d
to
45a59e2
Compare
55f9818
to
24f41cf
Compare
1eb3c72
to
8207fae
Compare
@Dishti-Oberai I've marked this as awaiting update, since I assume you're still working on tests. |
Thanks for reminding me regarding this @neiljp ! |
5d14499
to
76d47f8
Compare
a484b3e
to
b7f894b
Compare
@zulipbot add "PR needs review" |
9c0b3b2
to
711d937
Compare
711d937
to
229e3f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dishti-Oberai I left comments in the stream.
The test changes so far make the tests pass, but they don't yet cover the behavior, which is why I can change the new logic and still get the tests to pass.
229e3f5
to
e5622e3
Compare
Heads up @Dishti-Oberai, we just merged some commits that conflict with the changes you made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
What does this PR do?

This PR enhances the display of consecutive starred and/or unstarred messages which have identical dates, times, and authors.
Earlier all such messages which had similar star status (whether starred or unstarred) appeared together and messages which had different star status were separated by a line. However, this led to difficulty in identifying the star status of messages (which were starred and thus appeared together). The following screenshot depicts the same-
Now, all starred messages and messages which have different star statuses have been separated by a blank line whereas those which are all unstarred appear together. This leads to a better visual display and interpretation of the star status of messages.

The following screenshot demonstrates the present scenario-
(The first two messages are starred and the third one is unstarred in both the above screenshots)
Fixes #171
A detailed explanation of the issue and discussion related to it can be read at - https://chat.zulip.org/#narrow/stream/206-zulip-terminal/topic/Message.20merging.20-.20star.20status.20.28issue.20.23T171.29
Tested?
Notes & Questions
Should any other changes be made?
Interactions
The changes have been made (developed on) in addition to the following PR - #335
Visual changes



Earlier-
Presently-



