Enhance adaptive suprathreshold#2302
Merged
Merged
Conversation
t-b
force-pushed
the
feature/2302-another-adaptive-revision
branch
from
daec7e1 to
886e9e6
Compare
t-b
force-pushed
the
feature/2302-another-adaptive-revision
branch
2 times, most recently
from
d7b9af8 to
7a4e927
Compare
t-b
force-pushed
the
feature/2302-another-adaptive-revision
branch
3 times, most recently
from
87bc99b to
03ebd15
Compare
This comment was marked as outdated.
This comment was marked as outdated.
t-b
force-pushed
the
feature/2302-another-adaptive-revision
branch
2 times, most recently
from
c643b38 to
eaa0825
Compare
timjarsky
reviewed
Jan 27, 2025
t-b
force-pushed
the
feature/2302-another-adaptive-revision
branch
2 times, most recently
from
00b6e6f to
ae1e170
Compare
This comment was marked as outdated.
This comment was marked as outdated.
t-b
force-pushed
the
feature/2302-another-adaptive-revision
branch
from
ae1e170 to
17d9733
Compare
This comment was marked as outdated.
This comment was marked as outdated.
t-b
force-pushed
the
feature/2302-another-adaptive-revision
branch
from
17d9733 to
82df058
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Requested by Tim Jarsky.
…e front In a future commit we will add a second caller and that should not need to copy the code from the existing call site.
When we finished the last "PSQ_DAScale Adaptive" run with a failed set QC we now gather the future DAScale values of the very last one from the RhSuAd sweeps. As this was the plan to acquire for the previous SCI, this is still something we want to pursue now. We don't need to look into other SCIs, as we have already searched for them in the earliers SCIs.
As the unit is % Hz / pA and we get DAScale in units of pA, we don't need to convert to/from pA. This makes the numerical values much more pleasant to deal with.
t-b
force-pushed
the
feature/2302-another-adaptive-revision
branch
from
05652bb to
12684bd
Compare
Collaborator
Author
|
@timjarsky Ready for a test. Tests and flowchart are already updated. |
Collaborator
|
@t-b I looked at several files from the latest version of adaptive. The data looks good. A minor issue is the y-axis label on the lower plot (see below). I was expecting the lower plot y-axis to be % slope. 
|
Collaborator
Author
Collaborator
@t-b slope percent shouldn't be 10e-12, should it? |
…xSlope Broken since 41f05c7 (PSQ_DS_DAScale (Adapt): Add MinimumSpikeCountForMaxSlope analysis parameter, 2025-02-14).
Collaborator
Author
Nope, I fixed that. I also can't reproduce it, are you sure you are using the latest version? If yes, we can also do a screen share. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #2258
Next round after 7739d31 (PSQ_DS_FitFrequencyCurrentData: Remove it, 2025-01-28):
Decide about default values, see Enhance adaptive suprathreshold #2302 (comment)