-
Notifications
You must be signed in to change notification settings - Fork 9
Various PSX fixes #2362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
t-b
wants to merge
51
commits into
main
Choose a base branch
from
bugfix/2362-psx-support-multiple-selections
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Various PSX fixes #2362
Changes from all commits
Commits
Show all changes
51 commits
Select commit
Hold shift + click to select a range
4ba734f
PSX_RestoreGuiState: Prefer GUI control setter over PGC
t-b 694e4de
PSX_GetEventIndexAndComboIndex: Handle vs in keyboard navigation
t-b 31968f4
PSX: Tweak detection algorithm
timjarsky b5174c5
PSX: Calculate the starting point for the average fit better
t-b 36190c7
PSX_GetEventFitRange: Change starting position
t-b facdd0c
PSX_CalculateEventProperties: Tweak baseline calculation
t-b 0f87b96
UTF_SweepFormula_PSX.ipf: Fix tests
t-b bd31c79
PSX_GetGoodTau: Handle edge case
t-b 065f9d2
MIES_SweepFormula_PSX.ipf: Tweak PSX_TAU_CALC_FACTOR
timjarsky 46e53a4
MIES_SweepFormula_PSX.ipf: Tweak peak and baseline calculation
t-b f7c42c0
PSX_CalculateRiseTime: Factor it out
t-b 8049b5d
PSX_CalculateRiseTime: Return error when xStart is NaN
t-b bd2d5cb
PSX_UpdateDisplayedFit: Remove yOffset
t-b 12785da
PSX_FitAcceptAverage: Use different method for calculating start posi…
t-b a2464de
MIES_SweepFormula_PSX.ipf: Revise event peak and baseline calculation
t-b 96d3216
PSX_GetEventFitRange/PSX_FitEventDecay: Revise them
t-b 4ebc2f6
PSX_FitEventDecay: Switch from single exponential to double exponenti…
timjarsky 31c79e2
PSX_FitAcceptAverage: Multiple simultaneous fits to the accepted all …
timjarsky 85f48ee
PSX_FilterEventsKernelAmpSign: Ignore events with non-finite deconv v…
t-b 6c0764e
PSX: Add more vertical lines for peak_t and baseline_t
t-b 6cbecb5
PSX_FitEventDecay: Support three tau instead of one
t-b 8bbc1ec
stopping the collapse of the universe by filtering out negative time …
timjarsky 89c809c
another tau filter
timjarsky 13022bc
BandPassWithRingingDetection: Add it
timjarsky aa05ae8
psxDeconvFilter: Rework it
t-b 9151a43
MIES_SweepFormula_PSX.ipf: Document SweepFormula operation signatures
t-b c229ad1
psxSweepBPFilter: Add it
t-b 7301f5b
PSX_FilterSweepData/PSX_DeconvoluteSweepData: Always make order even
t-b fdd0d1b
BandPassWithRingingDetection: Minor cleanup
t-b 9d35eca
BandPassWithRingingDetection: Remove the offset for every iteration
t-b d4633f3
BandPassWithRingingDetection: Reorganize the code
t-b 47ffc83
PSX_Operation: Fix data gathering after failure
t-b 5e0966a
Packages/doc/SweepFormula.rst: Update it
t-b 80cfee5
PSX: Use 2^x padding for FFT input
t-b 4a59144
PSX: Prefer odd number of historgram bins
timjarsky d850612
Revert "PSX: Use 2^x padding for FFT input"
timjarsky 078ed82
PSX_FitAcceptAverage: Calculate maximum of it as well
t-b fa55e69
PSX: Add average fit for all states
t-b 2387ca4
MIES_Utilities_Algorithm.ipf: Add helper routines for DoFFT
t-b bebaa38
PSX: Implement sweep data shortening for faster FFT
t-b 1d03076
PSX: Supply default values for filtering derived from the kernel
t-b 282b111
PSX: Add Onset and Rise y values to psxEvent
t-b 5e04066
PSX_FitAverage: Store fit results in datafolder hierarchy
t-b db96e98
Packages/doc/SweepFormula.rst: Add units for rise and decay tau
t-b 5a6bdcf
PSX_Operation: Add peakThreshold to parameter JSON
t-b a651366
PSX_OperationStatsImpl: Output more entries for stats postprocessing
t-b 79445d3
Tim's questionable changes :)
timjarsky 4cbb3a8
PSX_UpdateAverageTraces: Fix indexing confusion
t-b 53d99a0
new function to determine the fit end time for the decay to the avera…
timjarsky d9ddd44
Update Packages/MIES/MIES_SweepFormula_PSX.ipf
timjarsky ba0dc32
Update Packages/MIES/MIES_SweepFormula_PSX.ipf
timjarsky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.