SF_OperationPowerSpectrum: Fix average option with SweepBrowser data#2418
Merged
Conversation
t-b
added
the
PR:NeedsBackport
Since fd5ee28 (SF: Use correct LNB getter in SF_GetTraceColor, 2024-10-04) we require mapIndex to be valid when fetching the labnotebook for sweep data in SF_GetTraceColor. But average data was always treated sweep-like but that does not have a map index. This can also be not easily fixed as it is not clear which mapIndex to use for sweeps from multiple experiments. Instead we now use the default average color. This also makes the metadata entry SF_META_AVERAGED_FIRST_SWEEP obsolete.
t-b
force-pushed
the
bugfix/2418-powerspectrum-average-sweepbrowser
branch
from
60c0caf to
ef30c2d
Compare
t-b
removed
the
PR:NeedsBackport
Collaborator
|
looks good
|
timjarsky
approved these changes
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since fd5ee28 (SF: Use correct LNB getter in SF_GetTraceColor,
2024-10-04) we require mapIndex to be valid when fetching the labnotebook
for sweep data in SF_GetTraceColor.
But average data was always treated sweep-like but that does not have a
map index. This can also be not easily fixed as it is not clear which mapIndex to use
for sweeps from multiple experiments. Instead we now use the default
average color.
This also makes the metadata entry SF_META_AVERAGED_FIRST_SWEEP obsolete.
Close #2390