pressure FFI #2561
Open
pressure FFI #2561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements a Foreign Function Interface (FFI) for pressure control operations, resolving get and set functionality for issue #2546. The changes refactor pressure control code by moving constants to a centralized location, promoting internal functions to public API functions, and adding new FFI functions for external pressure control.
Key changes:
- Moved pressure-related constants (
ATMOSPHERIC_PRESSURE,ACCESS_*) fromMIES_PressureControl.ipftoMIES_Constants.ipffor better code organization - Changed four internal pressure control functions to public API by removing
statickeywords - Added new FFI functions
FFI_GetWithOptionToSetPressure()andFFI_WaitForIdle()for external pressure control operations - Renamed
P_GetPressureMode()toP_GetPressureMethod()for consistency
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| MIES_PressureControl.ipf | Removed pressure constants, promoted four functions from static to public, removed old DoPressureManual(), renamed P_GetPressureMode() to P_GetPressureMethod() |
| MIES_ForeignFunctionInterface.ipf | Added FFI functions for pressure control including FFI_GetWithOptionToSetPressure(), FFI_WaitForIdle(), and several test functions |
| MIES_DAEphys.ipf | Updated function call from P_GetPressureMode() to P_GetPressureMethod() |
| MIES_Constants.ipf | Added pressure constants previously in MIES_PressureControl.ipf |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
479
to
493
| if(!PD[headstage][%OngoingPessurePulse]) | ||
| return 1 | ||
| endif | ||
|
|
||
| variable t0 = stopmstimer(-2) | ||
| // Wait until the pulse finishes or timeout elapses | ||
| do | ||
| if(!PD[headstage][%OngoingPessurePulse]) | ||
| return 1 | ||
| endif | ||
|
|
||
| // Timeout check (treating stopmstimer(-2) deltas as milliseconds) | ||
| if((stopmstimer(-2) - t0) > (kPressurePulseMaxMS + kPressureWaitSlackMS)) | ||
| // one last check before giving up | ||
| return !PD[headstage][%OngoingPessurePulse] |
There was a problem hiding this comment.
Corrected spelling of 'OngoingPessurePulse' to 'OngoingPressurePulse' (assuming this is the correct column name based on context).
Suggested change
| if(!PD[headstage][%OngoingPessurePulse]) | |
| return 1 | |
| endif | |
| variable t0 = stopmstimer(-2) | |
| // Wait until the pulse finishes or timeout elapses | |
| do | |
| if(!PD[headstage][%OngoingPessurePulse]) | |
| return 1 | |
| endif | |
| // Timeout check (treating stopmstimer(-2) deltas as milliseconds) | |
| if((stopmstimer(-2) - t0) > (kPressurePulseMaxMS + kPressureWaitSlackMS)) | |
| // one last check before giving up | |
| return !PD[headstage][%OngoingPessurePulse] | |
| if(!PD[headstage][%OngoingPressurePulse]) | |
| return 1 | |
| endif | |
| variable t0 = stopmstimer(-2) | |
| // Wait until the pulse finishes or timeout elapses | |
| do | |
| if(!PD[headstage][%OngoingPressurePulse]) | |
| return 1 | |
| endif | |
| // Timeout check (treating stopmstimer(-2) deltas as milliseconds) | |
| if((stopmstimer(-2) - t0) > (kPressurePulseMaxMS + kPressureWaitSlackMS)) | |
| // one last check before giving up | |
| return !PD[headstage][%OngoingPressurePulse] |
Comment on lines
479
to
493
| if(!PD[headstage][%OngoingPessurePulse]) | ||
| return 1 | ||
| endif | ||
|
|
||
| variable t0 = stopmstimer(-2) | ||
| // Wait until the pulse finishes or timeout elapses | ||
| do | ||
| if(!PD[headstage][%OngoingPessurePulse]) | ||
| return 1 | ||
| endif | ||
|
|
||
| // Timeout check (treating stopmstimer(-2) deltas as milliseconds) | ||
| if((stopmstimer(-2) - t0) > (kPressurePulseMaxMS + kPressureWaitSlackMS)) | ||
| // one last check before giving up | ||
| return !PD[headstage][%OngoingPessurePulse] |
There was a problem hiding this comment.
Corrected spelling of 'OngoingPessurePulse' to 'OngoingPressurePulse' (assuming this is the correct column name based on context).
Suggested change
| if(!PD[headstage][%OngoingPessurePulse]) | |
| return 1 | |
| endif | |
| variable t0 = stopmstimer(-2) | |
| // Wait until the pulse finishes or timeout elapses | |
| do | |
| if(!PD[headstage][%OngoingPessurePulse]) | |
| return 1 | |
| endif | |
| // Timeout check (treating stopmstimer(-2) deltas as milliseconds) | |
| if((stopmstimer(-2) - t0) > (kPressurePulseMaxMS + kPressureWaitSlackMS)) | |
| // one last check before giving up | |
| return !PD[headstage][%OngoingPessurePulse] | |
| if(!PD[headstage][%OngoingPressurePulse]) | |
| return 1 | |
| endif | |
| variable t0 = stopmstimer(-2) | |
| // Wait until the pulse finishes or timeout elapses | |
| do | |
| if(!PD[headstage][%OngoingPressurePulse]) | |
| return 1 | |
| endif | |
| // Timeout check (treating stopmstimer(-2) deltas as milliseconds) | |
| if((stopmstimer(-2) - t0) > (kPressurePulseMaxMS + kPressureWaitSlackMS)) | |
| // one last check before giving up | |
| return !PD[headstage][%OngoingPressurePulse] |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Get and Set of #2546