Enhance Wave Reference Wave Browser#2718
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enhances the Wave Reference Wave Browser with contextual entry points from tables and the data browser, plus richer preview/navigation UI for referenced waves.
Changes:
- Adds dynamic context menu items for table columns and data browser selections.
- Adds an attached preview table with tooltip-based inspection and keyboard navigation.
- Adds wave type/preview formatting helpers and tooltip-location storage.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
Packages/MIES/MIES_WaverefBrowser.ipf |
Adds context menus, preview table, tooltip display, and nested wave-reference navigation. |
Packages/MIES/MIES_WaveDataFolderGetters.ipf |
Adds storage for the last tooltip location used by keyboard navigation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MichaelHuth
force-pushed
the
feature/2718-enhance_WRB
branch
from
34514c2 to
8fac104
Compare
MichaelHuth
force-pushed
the
feature/2718-enhance_WRB
branch
from
8fac104 to
2dc26a5
Compare
MichaelHuth
force-pushed
the
feature/2718-enhance_WRB
branch
from
2dc26a5 to
3ba53a6
Compare
MichaelHuth
force-pushed
the
feature/2718-enhance_WRB
branch
from
3ba53a6 to
9016f6d
Compare
Collaborator
Author
|
@copilot Review this PR |
Contributor
I reviewed the PR state and reran checks from my side. The previously reported issues are already addressed in the current branch state, and local pre-commit linting passes. The earlier CI failure was on an older commit; the newer run for the current head is in progress. |
MichaelHuth
force-pushed
the
feature/2718-enhance_WRB
branch
from
a822bd8 to
4b8493b
Compare
MichaelHuth
force-pushed
the
feature/2718-enhance_WRB
branch
from
4b8493b to
9ee01b8
Compare
- add context menu on wave reference waves in data browser - add context menu for columns in tables to open WRB - add preview of the first 10 points in the sub wave - add attached subwindow that shows the current waveref wave in a table The table allows to navigate on multidimensional waves and to browse further. Due to Igor Pro limitations the workflow is like: On tooltip popup the marked element is moved. Press enter to open the last wave reference wave where a tooltip was last shown. (The marked element is for visualization only)
MichaelHuth
force-pushed
the
feature/2718-enhance_WRB
branch
from
9ee01b8 to
3ba6882
Compare
Collaborator
|
Works here. I have only skimmed over the code. |
t-b
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The table allows to navigate on multidimensional waves and to browse further. Due to Igor Pro limitations the workflow is like:
Press enter to open the last wave reference wave where a tooltip was shown.
close #2672