Skip to content

ACD_InitDAQSettingsFromString: Return the struct via MRS#2720

Merged
t-b merged 2 commits into
mainfrom
bugfix/2720-various-fixes
Jun 2, 2026
Merged

ACD_InitDAQSettingsFromString: Return the struct via MRS#2720
t-b merged 2 commits into
mainfrom
bugfix/2720-various-fixes

Conversation

@t-b
Copy link
Copy Markdown
Collaborator

@t-b t-b commented Jun 1, 2026

This is better practice.

Will merge once CI passes.

@t-b t-b self-assigned this Jun 1, 2026
Copilot AI review requested due to automatic review settings June 1, 2026 22:00
@t-b t-b requested review from MichaelHuth and timjarsky as code owners June 1, 2026 22:00
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors ACD_InitDAQSettingsFromString from filling a struct via pass-by-reference to returning the struct using Igor Pro's multiple-return-syntax (MRS). All callers in the hardware test suites are updated to the new [STRUCT ACD_DAQSettings s] = ACD_InitDAQSettingsFromString(...) form, and the doc-comment example is adjusted accordingly.

Changes:

  • Change ACD_InitDAQSettingsFromString signature to return the struct via MRS and update its doc example.
  • Mechanically update all test callers under Packages/tests/HardwareBasic/ and Packages/tests/HardwareAnalysisFunctions/ to use the new MRS form, removing the now-unnecessary standalone STRUCT ACD_DAQSettings s declarations.
  • An unrelated LBV_Update(graph) call is added at the end of LBV_AddTraceToLBGraph in MIES_LogbookViewer.ipf.

Reviewed changes

Copilot reviewed 31 out of 31 changed files in this pull request and generated 1 comment.

File Description
Packages/MIES/MIES_AcquireData.ipf Converts ACD_InitDAQSettingsFromString to MRS return and updates its example.
Packages/MIES/MIES_LogbookViewer.ipf Adds LBV_Update(graph) at end of LBV_AddTraceToLBGraph (unrelated to PR title).
Packages/tests/HardwareBasic/UTF_*.ipf (many) Updates test callers to MRS form, removes redundant struct decls.
Packages/tests/HardwareAnalysisFunctions/UTF_*.ipf (many) Same caller updates in analysis-function tests.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Packages/MIES/MIES_LogbookViewer.ipf
@t-b t-b merged commit 200e594 into main Jun 2, 2026
23 checks passed
@t-b t-b deleted the bugfix/2720-various-fixes branch June 2, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants