ACD_InitDAQSettingsFromString: Return the struct via MRS#2720
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Refactors ACD_InitDAQSettingsFromString from filling a struct via pass-by-reference to returning the struct using Igor Pro's multiple-return-syntax (MRS). All callers in the hardware test suites are updated to the new [STRUCT ACD_DAQSettings s] = ACD_InitDAQSettingsFromString(...) form, and the doc-comment example is adjusted accordingly.
Changes:
- Change
ACD_InitDAQSettingsFromStringsignature to return the struct via MRS and update its doc example. - Mechanically update all test callers under
Packages/tests/HardwareBasic/andPackages/tests/HardwareAnalysisFunctions/to use the new MRS form, removing the now-unnecessary standaloneSTRUCT ACD_DAQSettings sdeclarations. - An unrelated
LBV_Update(graph)call is added at the end ofLBV_AddTraceToLBGraphinMIES_LogbookViewer.ipf.
Reviewed changes
Copilot reviewed 31 out of 31 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Packages/MIES/MIES_AcquireData.ipf | Converts ACD_InitDAQSettingsFromString to MRS return and updates its example. |
| Packages/MIES/MIES_LogbookViewer.ipf | Adds LBV_Update(graph) at end of LBV_AddTraceToLBGraph (unrelated to PR title). |
| Packages/tests/HardwareBasic/UTF_*.ipf (many) | Updates test callers to MRS form, removes redundant struct decls. |
| Packages/tests/HardwareAnalysisFunctions/UTF_*.ipf (many) | Same caller updates in analysis-function tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is better practice.
Will merge once CI passes.