Further improvement of AI instructions#2739
Open
MichaelHuth wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the internal Igor Pro wave/datafolder reference guidance to reduce AI-generated mistakes by clarifying two common language gotchas: (1) when WAVE statements raise runtime errors (only when executed without /Z and the RHS can’t resolve), and (2) what size Make creates when /N is omitted.
Changes:
- Documented Igor’s function-level scoping/default-initialization behavior for reference-typed locals (
WAVE,NVAR,SVAR,DFREF,FUNCREF) with illustrative examples. - Added a concise explanation of the runtime-error distinction between an unexecuted
WAVEstatement vs an executed-but-unresolvable RHS (and when to use/Z). - Documented
Makedefault sizing rules when/Nis omitted (128-point default vs initializer-sized).
MichaelHuth
force-pushed
the
feature/2739-improve_ai_instructions
branch
from
July 8, 2026 23:15
07e1078 to
d126605
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
.claude/skills/igor-wave-dfref/SKILL.md:798
- Same issue here: the "Reference URLs" table row uses the URL column for a statement. Converting it to a link (or moving the statement into the body text) would keep the table’s meaning consistent.
| NVAR_Exists | https://docs.wavemetrics.com/igorpro/commands/nvar_exists |
| SVAR_Exists | https://docs.wavemetrics.com/igorpro/commands/svar_exists |
| `Concatenate` destination when every source across a loop is 0-row | Destination wave is still created, with 0 rows — never left null |
Comment on lines
784
to
787
| | Programming Techniques (DF patterns) | https://docs.wavemetrics.com/igorpro/programming/programming-techniques | | ||
| | WAVE keyword | https://docs.wavemetrics.com/igorpro/commands/wave | | ||
| | Conditionally-assigned WAVE ref used after the block | Safe — defaults to null if the branch didn't run, not an error | | ||
| | NewFreeWave | https://docs.wavemetrics.com/igorpro/commands/newfreewave | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If it occurs in reviews or other AI answers regarding Igor code that the answer is plainly wrong, please mention it here.
So the instructions can be improved.
for(elem : wv)loops to indexed ones withelem = wv[i]and the ordering of it