Skip to content

Move rudder arming up into RC_Channel library #16091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 26 commits into
base: master
Choose a base branch
from

Conversation

peterbarker
Copy link
Contributor

@peterbarker peterbarker commented Dec 17, 2020

This will make rudder-arming consistent across our vehicles.

One known behaviour change is that the rover arm interval has moved from 2 to 3 seconds (to be like Copter and Plane).

Other known changes in behaviour:

  • Copter and Rover will try to arm if your throttle is non-zero, and you will get a warning that your throttle is non-zero. In master we don't try to arm. I think this new behaviour is far preferable from a user's standpoint as they're told why they can't arm right now in the case they meant to arm! The new code has the same behaviour as Plane in master

We can't move the rudder-specific arming checks into the RC_Channels library as ToyMode also arms with a reason of "rudder" and presumably wants the same checks

@peterbarker peterbarker force-pushed the pr/rudder-arming-up branch 3 times, most recently from 5570908 to f71ac3b Compare December 18, 2020 03:13
@peterbarker peterbarker force-pushed the pr/rudder-arming-up branch 4 times, most recently from e7c327b to 827ff0d Compare January 1, 2021 01:55
@peterbarker peterbarker force-pushed the pr/rudder-arming-up branch 2 times, most recently from 157f4c3 to 9ef65ee Compare March 27, 2021 01:51
@peterbarker peterbarker removed the WIP label Apr 1, 2021
@peterbarker peterbarker force-pushed the pr/rudder-arming-up branch from 9ef65ee to 24377cf Compare April 1, 2021 14:04
@peterbarker
Copy link
Contributor Author

Tested in SITL - standard arming and RUDDER_DISARM values.

@peterbarker peterbarker force-pushed the pr/rudder-arming-up branch 3 times, most recently from ab489a5 to 2815824 Compare April 6, 2021 06:41
@tridge tridge removed the DevCallEU label Apr 7, 2021
@tridge
Copy link
Contributor

tridge commented Apr 7, 2021

@rmackay9 also noted on the call that he's happy for the 10s trim feature to be removed if whoever removes it ensures docs are updated

@rmackay9
Copy link
Contributor

rmackay9 commented Apr 7, 2021

Docs for autotrim are here: https://ardupilot.org/copter/docs/autotrim.html and here: https://ardupilot.org/copter/docs/arming_the_motors.html. The 2nd link in particular has a warning that could be updated to be clear it only applies to 4.0 (and earlier)

@peterbarker peterbarker force-pushed the pr/rudder-arming-up branch from ab438ea to 3e5b04c Compare April 16, 2025 09:55
the arm/disarm cases were identical, so reuse the code
stops uwarning the user instantly
we do not run the arming checks if ARMING_CHECK is zero
this was ineffective as Blimp was not enforcing the parameter.  We do now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

6 participants