-
Notifications
You must be signed in to change notification settings - Fork 18.5k
Move rudder arming up into RC_Channel library #16091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
5570908
to
f71ac3b
Compare
e7c327b
to
827ff0d
Compare
827ff0d
to
8bc7e33
Compare
8bc7e33
to
65df351
Compare
157f4c3
to
9ef65ee
Compare
9ef65ee
to
24377cf
Compare
Tested in SITL - standard arming and RUDDER_DISARM values. |
ab489a5
to
2815824
Compare
@rmackay9 also noted on the call that he's happy for the 10s trim feature to be removed if whoever removes it ensures docs are updated |
Docs for autotrim are here: https://ardupilot.org/copter/docs/autotrim.html and here: https://ardupilot.org/copter/docs/arming_the_motors.html. The 2nd link in particular has a warning that could be updated to be clear it only applies to 4.0 (and earlier) |
ab438ea
to
3e5b04c
Compare
the arm/disarm cases were identical, so reuse the code
stops uwarning the user instantly
we do not run the arming checks if ARMING_CHECK is zero
this was ineffective as Blimp was not enforcing the parameter. We do now
f763f15
to
a183f60
Compare
This will make rudder-arming consistent across our vehicles.
One known behaviour change is that the rover arm interval has moved from 2 to 3 seconds (to be like Copter and Plane).
Other known changes in behaviour:
We can't move the rudder-specific arming checks into the RC_Channels library as ToyMode also arms with a reason of "rudder" and presumably wants the same checks