-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Fix InjectionToken types to allow new inject(Token) syntax to be used with msal-angular. #7653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: msal-v5
Are you sure you want to change the base?
Conversation
@shylasummers this branch resolves all of the issues from the other PR |
Hi @bradkovach, looks like you still need to adjust the changefile. This is a major (breaking) change. Try deleting this changefile and re-running while selecting major as the type. |
@bradkovach bumping the request for a changefile fix |
@bradkovach bumping one more time for the changefile fix |
@shylasummers new beachballs are available for you |
@bradkovach Please change the changefile type to major. You also only should have one changefile. |
I sent this in as a breaking change even though it doesn't break anything because old, improper types had to be manually over-ridden, so those type casts will still be in place when folks upgrade. Since you're targeting this for v5, I don't think that matters. However, since there were concerns, I authored a unit test that uses |
(desc copied from #7484)
This PR adjusts
InjectionToken
instantiation to use the proper template type parameter (instead ofstring
), so that the new Angular 14+inject(TOKEN)
syntax can be used if desired.