Update KHR_materials_variants to latest spec #8739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deltakosh
approved these changes
Aug 14, 2020
deltakosh
added a commit
that referenced
this pull request
Aug 14, 2020
* Expose feature points in BabylonJS as a native extension. * Expose setFeaturePointCloudEnabled in XRSession, and add it to the startup routine for the feature * Add some comments and minor cleanup * Fix some minor spacing issues * Add id to feature point data. * fix indexing of confidence value and ID. * Maintain feature point cloud across frames, signal with our collection every frame. * Change onFeaturePointsUpdatedObservable to signal with a list of updated Ids so that we can keep track what has changed between frames. * Fix doubled size array from doing both a distinct size declaration and .push. * Add in doc describing implementation of FeaturePoints into LibDeclarations. * Cleanup, make exposed array readonly and use private member variable to do internal accounting. * Updating What's new, and move private member variable to unbreak typedoc. * Apply suggestions from code review Co-authored-by: Ryan Tremblay <[email protected]> * Address PR comments. Split feature point updates into added, and updated. * Change setFeaturePointCloudEnabled to trySetFeaturePointEnabled. * Address PR comments. * Make feature names readonly. * Make it so ids do not need to be sequential. * Add option in default pipeline property grid to convert cc to gamma or linear * Nightly * Nightly * Update KHR_materials_variants to latest spec (#8739) * remove reset button for variants * Fix thin instance bounding info computation (#8740) * Nightly Co-authored-by: Alex Tran <[email protected]> Co-authored-by: Ryan Tremblay <[email protected]> Co-authored-by: Gary Hsu <[email protected]> Co-authored-by: Raanan Weber <[email protected]> Co-authored-by: Popov72 <[email protected]>
deltakosh
added a commit
that referenced
this pull request
Aug 17, 2020
* Expose feature points in BabylonJS as a native extension. * Expose setFeaturePointCloudEnabled in XRSession, and add it to the startup routine for the feature * Add some comments and minor cleanup * Fix some minor spacing issues * Add id to feature point data. * fix indexing of confidence value and ID. * Maintain feature point cloud across frames, signal with our collection every frame. * Change onFeaturePointsUpdatedObservable to signal with a list of updated Ids so that we can keep track what has changed between frames. * Fix doubled size array from doing both a distinct size declaration and .push. * Add in doc describing implementation of FeaturePoints into LibDeclarations. * Cleanup, make exposed array readonly and use private member variable to do internal accounting. * Updating What's new, and move private member variable to unbreak typedoc. * Apply suggestions from code review Co-authored-by: Ryan Tremblay <[email protected]> * Address PR comments. Split feature point updates into added, and updated. * Change setFeaturePointCloudEnabled to trySetFeaturePointEnabled. * Address PR comments. * Make feature names readonly. * Make it so ids do not need to be sequential. * Add option in default pipeline property grid to convert cc to gamma or linear * Nightly * Nightly * Update KHR_materials_variants to latest spec (#8739) * remove reset button for variants * Fix thin instance bounding info computation (#8740) * Nightly * Add some precision to the doc of onMeshLoaded callback / observable (#8743) * Allow enabling the stencil buffer when using CreateScreenshotUsingRenderTarget (#8748) * fix updateOptions issue (#8746) * Optional entity types array for XR hit-test * fix updateOptions issue * linting * remove unneeded character * 4.2.0-alpha.33 Co-authored-by: Alex Tran <[email protected]> Co-authored-by: Ryan Tremblay <[email protected]> Co-authored-by: Gary Hsu <[email protected]> Co-authored-by: Raanan Weber <[email protected]> Co-authored-by: Popov72 <[email protected]>
deltakosh
added a commit
that referenced
this pull request
Aug 18, 2020
* Expose feature points in BabylonJS as a native extension. * Expose setFeaturePointCloudEnabled in XRSession, and add it to the startup routine for the feature * Add some comments and minor cleanup * Fix some minor spacing issues * Add id to feature point data. * fix indexing of confidence value and ID. * Maintain feature point cloud across frames, signal with our collection every frame. * Change onFeaturePointsUpdatedObservable to signal with a list of updated Ids so that we can keep track what has changed between frames. * Fix doubled size array from doing both a distinct size declaration and .push. * Add in doc describing implementation of FeaturePoints into LibDeclarations. * Cleanup, make exposed array readonly and use private member variable to do internal accounting. * Updating What's new, and move private member variable to unbreak typedoc. * Apply suggestions from code review Co-authored-by: Ryan Tremblay <[email protected]> * Address PR comments. Split feature point updates into added, and updated. * Change setFeaturePointCloudEnabled to trySetFeaturePointEnabled. * Optional entity types array for XR hit-test * Address PR comments. * Make feature names readonly. * Make it so ids do not need to be sequential. * Add option in default pipeline property grid to convert cc to gamma or linear * Nightly * Nightly * Update KHR_materials_variants to latest spec (#8739) * remove reset button for variants * Fix thin instance bounding info computation (#8740) * Nightly * Add some precision to the doc of onMeshLoaded callback / observable (#8743) * Allow enabling the stencil buffer when using CreateScreenshotUsingRenderTarget (#8748) * fix updateOptions issue (#8746) * Optional entity types array for XR hit-test * fix updateOptions issue * linting * remove unneeded character * 4.2.0-alpha.33 * Update sphereBuilder.ts (#8750) * Update sphereBuilder.ts Fix sphereBuilder adding 6 indices to the top and bottom segments of sphere (even there's only 1 triangle) * Update what's new.md (#12) * Update sphereBuilder.ts * Fix linting * expose overlay, add css class * say what say waht say what is new (what is new!) * Update webXREnterExitUI.ts * [XR] Make sure any model will work with the controller loop (#8758) * Optional entity types array for XR hit-test * defensively dealing with missing valueMesh (thou unlikely) * Fix playground examples loading (#8756) * Optional entity types array for XR hit-test * Fix example-loading issues * Flat tangent (#8751) * Flat tangent * Whats new * whats new Co-authored-by: Alejandro Toledo <[email protected]> * [XR] WebXR Hand Tracking - initial support (#8753) * Optional entity types array for XR hit-test * hand tracking declaration * depends on and hand tracking name * defensive * added the hand tracking feature * nuwat * fix non-supporting-system issue * make sure model is disposedif the controller is already disposed * disable pointer selection for hand tracking * new observers, physics config * documentation * linting * code doc * fixing the d.ts issue * extends instead of implements * Fix potential recursive calls (#8757) * nightly * [XR] Setting default values for the XR creation context (#8759) Stencil state is takes from the engine (or overridden) * KTX2 transcoders (#8760) * Fix potential recursive calls * Add the ktx2 transcoders * Nightly * Nightly Co-authored-by: Alex Tran <[email protected]> Co-authored-by: Ryan Tremblay <[email protected]> Co-authored-by: Raanan Weber <[email protected]> Co-authored-by: Gary Hsu <[email protected]> Co-authored-by: Popov72 <[email protected]> Co-authored-by: aWeirdo <[email protected]> Co-authored-by: Alejandro Toledo Martinez <[email protected]> Co-authored-by: Alejandro Toledo <[email protected]>
Merged
deltakosh
added a commit
that referenced
this pull request
Aug 18, 2020
* Expose feature points in BabylonJS as a native extension. * Expose setFeaturePointCloudEnabled in XRSession, and add it to the startup routine for the feature * Add some comments and minor cleanup * Fix some minor spacing issues * Add id to feature point data. * fix indexing of confidence value and ID. * Maintain feature point cloud across frames, signal with our collection every frame. * Change onFeaturePointsUpdatedObservable to signal with a list of updated Ids so that we can keep track what has changed between frames. * Fix doubled size array from doing both a distinct size declaration and .push. * Add in doc describing implementation of FeaturePoints into LibDeclarations. * Cleanup, make exposed array readonly and use private member variable to do internal accounting. * Updating What's new, and move private member variable to unbreak typedoc. * Apply suggestions from code review Co-authored-by: Ryan Tremblay <[email protected]> * Address PR comments. Split feature point updates into added, and updated. * Change setFeaturePointCloudEnabled to trySetFeaturePointEnabled. * Optional entity types array for XR hit-test * Address PR comments. * Make feature names readonly. * Make it so ids do not need to be sequential. * Add option in default pipeline property grid to convert cc to gamma or linear * Nightly * Nightly * Update KHR_materials_variants to latest spec (#8739) * remove reset button for variants * Fix thin instance bounding info computation (#8740) * Nightly * Add some precision to the doc of onMeshLoaded callback / observable (#8743) * Allow enabling the stencil buffer when using CreateScreenshotUsingRenderTarget (#8748) * fix updateOptions issue (#8746) * Optional entity types array for XR hit-test * fix updateOptions issue * linting * remove unneeded character * 4.2.0-alpha.33 * Update sphereBuilder.ts (#8750) * Update sphereBuilder.ts Fix sphereBuilder adding 6 indices to the top and bottom segments of sphere (even there's only 1 triangle) * Update what's new.md (#12) * Update sphereBuilder.ts * Fix linting * expose overlay, add css class * say what say waht say what is new (what is new!) * Update webXREnterExitUI.ts * [XR] Make sure any model will work with the controller loop (#8758) * Optional entity types array for XR hit-test * defensively dealing with missing valueMesh (thou unlikely) * Fix playground examples loading (#8756) * Optional entity types array for XR hit-test * Fix example-loading issues * Flat tangent (#8751) * Flat tangent * Whats new * whats new Co-authored-by: Alejandro Toledo <[email protected]> * [XR] WebXR Hand Tracking - initial support (#8753) * Optional entity types array for XR hit-test * hand tracking declaration * depends on and hand tracking name * defensive * added the hand tracking feature * nuwat * fix non-supporting-system issue * make sure model is disposedif the controller is already disposed * disable pointer selection for hand tracking * new observers, physics config * documentation * linting * code doc * fixing the d.ts issue * extends instead of implements * Fix potential recursive calls (#8757) * nightly * [XR] Setting default values for the XR creation context (#8759) Stencil state is takes from the engine (or overridden) * KTX2 transcoders (#8760) * Fix potential recursive calls * Add the ktx2 transcoders * Nightly * Nightly Co-authored-by: Alex Tran <[email protected]> Co-authored-by: Ryan Tremblay <[email protected]> Co-authored-by: Raanan Weber <[email protected]> Co-authored-by: Gary Hsu <[email protected]> Co-authored-by: Popov72 <[email protected]> Co-authored-by: aWeirdo <[email protected]> Co-authored-by: Alejandro Toledo Martinez <[email protected]> Co-authored-by: Alejandro Toledo <[email protected]> Co-authored-by: Alex Tran <[email protected]> Co-authored-by: Ryan Tremblay <[email protected]> Co-authored-by: Raanan Weber <[email protected]> Co-authored-by: Gary Hsu <[email protected]> Co-authored-by: Popov72 <[email protected]> Co-authored-by: aWeirdo <[email protected]> Co-authored-by: Alejandro Toledo Martinez <[email protected]> Co-authored-by: Alejandro Toledo <[email protected]>
deltakosh
added a commit
that referenced
this pull request
Aug 18, 2020
* Expose feature points in BabylonJS as a native extension. * Expose setFeaturePointCloudEnabled in XRSession, and add it to the startup routine for the feature * Add some comments and minor cleanup * Fix some minor spacing issues * Add id to feature point data. * fix indexing of confidence value and ID. * Maintain feature point cloud across frames, signal with our collection every frame. * Change onFeaturePointsUpdatedObservable to signal with a list of updated Ids so that we can keep track what has changed between frames. * Fix doubled size array from doing both a distinct size declaration and .push. * Add in doc describing implementation of FeaturePoints into LibDeclarations. * Cleanup, make exposed array readonly and use private member variable to do internal accounting. * Updating What's new, and move private member variable to unbreak typedoc. * Apply suggestions from code review Co-authored-by: Ryan Tremblay <[email protected]> * Address PR comments. Split feature point updates into added, and updated. * Change setFeaturePointCloudEnabled to trySetFeaturePointEnabled. * Optional entity types array for XR hit-test * Address PR comments. * Make feature names readonly. * Make it so ids do not need to be sequential. * Add option in default pipeline property grid to convert cc to gamma or linear * Nightly * Nightly * Update KHR_materials_variants to latest spec (#8739) * remove reset button for variants * Fix thin instance bounding info computation (#8740) * Nightly * Add some precision to the doc of onMeshLoaded callback / observable (#8743) * Allow enabling the stencil buffer when using CreateScreenshotUsingRenderTarget (#8748) * fix updateOptions issue (#8746) * Optional entity types array for XR hit-test * fix updateOptions issue * linting * remove unneeded character * 4.2.0-alpha.33 * Update sphereBuilder.ts (#8750) * Update sphereBuilder.ts Fix sphereBuilder adding 6 indices to the top and bottom segments of sphere (even there's only 1 triangle) * Update what's new.md (#12) * Update sphereBuilder.ts * Fix linting * expose overlay, add css class * say what say waht say what is new (what is new!) * Update webXREnterExitUI.ts * [XR] Make sure any model will work with the controller loop (#8758) * Optional entity types array for XR hit-test * defensively dealing with missing valueMesh (thou unlikely) * Fix playground examples loading (#8756) * Optional entity types array for XR hit-test * Fix example-loading issues * Flat tangent (#8751) * Flat tangent * Whats new * whats new Co-authored-by: Alejandro Toledo <[email protected]> * [XR] WebXR Hand Tracking - initial support (#8753) * Optional entity types array for XR hit-test * hand tracking declaration * depends on and hand tracking name * defensive * added the hand tracking feature * nuwat * fix non-supporting-system issue * make sure model is disposedif the controller is already disposed * disable pointer selection for hand tracking * new observers, physics config * documentation * linting * code doc * fixing the d.ts issue * extends instead of implements * Fix potential recursive calls (#8757) * nightly * [XR] Setting default values for the XR creation context (#8759) Stencil state is takes from the engine (or overridden) * KTX2 transcoders (#8760) * Fix potential recursive calls * Add the ktx2 transcoders * Nightly * Nightly * Nightly (#8761) (#8762) * Expose feature points in BabylonJS as a native extension. * Expose setFeaturePointCloudEnabled in XRSession, and add it to the startup routine for the feature * Add some comments and minor cleanup * Fix some minor spacing issues * Add id to feature point data. * fix indexing of confidence value and ID. * Maintain feature point cloud across frames, signal with our collection every frame. * Change onFeaturePointsUpdatedObservable to signal with a list of updated Ids so that we can keep track what has changed between frames. * Fix doubled size array from doing both a distinct size declaration and .push. * Add in doc describing implementation of FeaturePoints into LibDeclarations. * Cleanup, make exposed array readonly and use private member variable to do internal accounting. * Updating What's new, and move private member variable to unbreak typedoc. * Apply suggestions from code review Co-authored-by: Ryan Tremblay <[email protected]> * Address PR comments. Split feature point updates into added, and updated. * Change setFeaturePointCloudEnabled to trySetFeaturePointEnabled. * Optional entity types array for XR hit-test * Address PR comments. * Make feature names readonly. * Make it so ids do not need to be sequential. * Add option in default pipeline property grid to convert cc to gamma or linear * Nightly * Nightly * Update KHR_materials_variants to latest spec (#8739) * remove reset button for variants * Fix thin instance bounding info computation (#8740) * Nightly * Add some precision to the doc of onMeshLoaded callback / observable (#8743) * Allow enabling the stencil buffer when using CreateScreenshotUsingRenderTarget (#8748) * fix updateOptions issue (#8746) * Optional entity types array for XR hit-test * fix updateOptions issue * linting * remove unneeded character * 4.2.0-alpha.33 * Update sphereBuilder.ts (#8750) * Update sphereBuilder.ts Fix sphereBuilder adding 6 indices to the top and bottom segments of sphere (even there's only 1 triangle) * Update what's new.md (#12) * Update sphereBuilder.ts * Fix linting * expose overlay, add css class * say what say waht say what is new (what is new!) * Update webXREnterExitUI.ts * [XR] Make sure any model will work with the controller loop (#8758) * Optional entity types array for XR hit-test * defensively dealing with missing valueMesh (thou unlikely) * Fix playground examples loading (#8756) * Optional entity types array for XR hit-test * Fix example-loading issues * Flat tangent (#8751) * Flat tangent * Whats new * whats new Co-authored-by: Alejandro Toledo <[email protected]> * [XR] WebXR Hand Tracking - initial support (#8753) * Optional entity types array for XR hit-test * hand tracking declaration * depends on and hand tracking name * defensive * added the hand tracking feature * nuwat * fix non-supporting-system issue * make sure model is disposedif the controller is already disposed * disable pointer selection for hand tracking * new observers, physics config * documentation * linting * code doc * fixing the d.ts issue * extends instead of implements * Fix potential recursive calls (#8757) * nightly * [XR] Setting default values for the XR creation context (#8759) Stencil state is takes from the engine (or overridden) * KTX2 transcoders (#8760) * Fix potential recursive calls * Add the ktx2 transcoders * Nightly * Nightly Co-authored-by: Alex Tran <[email protected]> Co-authored-by: Ryan Tremblay <[email protected]> Co-authored-by: Raanan Weber <[email protected]> Co-authored-by: Gary Hsu <[email protected]> Co-authored-by: Popov72 <[email protected]> Co-authored-by: aWeirdo <[email protected]> Co-authored-by: Alejandro Toledo Martinez <[email protected]> Co-authored-by: Alejandro Toledo <[email protected]> Co-authored-by: Alex Tran <[email protected]> Co-authored-by: Ryan Tremblay <[email protected]> Co-authored-by: Raanan Weber <[email protected]> Co-authored-by: Gary Hsu <[email protected]> Co-authored-by: Popov72 <[email protected]> Co-authored-by: aWeirdo <[email protected]> Co-authored-by: Alejandro Toledo Martinez <[email protected]> Co-authored-by: Alejandro Toledo <[email protected]> Co-authored-by: Alex Tran <[email protected]> Co-authored-by: Ryan Tremblay <[email protected]> Co-authored-by: Raanan Weber <[email protected]> Co-authored-by: Gary Hsu <[email protected]> Co-authored-by: Popov72 <[email protected]> Co-authored-by: aWeirdo <[email protected]> Co-authored-by: Alejandro Toledo Martinez <[email protected]> Co-authored-by: Alejandro Toledo <[email protected]>
|
Woohoo! Thanks @bghgary !! |
|
@bghgary Soooo small change. I messed up the sample model and used Here's the fixed models: Mind doing that small change? Sorry about that! |
|
working on it :) |
|
Will be live in a couple of hours! Thanks for the update @pushmatrix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BabylonJS/Assets#6 must be merged for the tests to pass.
See KhronosGroup/glTF#1681 (comment) for context.