Conversation
|
Can we take a moment to dialog with Boris. I don't believe this workflow will work on pull_request b/c the workflow needs to push the change to the branch. I'll respond to Boris in just 1 moment. I'm comfortable with any approach though if we find this to be a risk. |
|
Let me give you a call @micahwiesner67. I agree this is breaking and after reading and thinking a bit more I agree it's not clear to me that there's a vulnerability here. |
|
Summarizing some Teams discussion:
I'm not sure how critical this workflow is day to day, but it clearly helps dependabot work seamlessly by updating the news.md file, which we need to ensure dependabot PRs pass CI tests. @giomrella will talk with Boris to see if we can get an exception. |
|
After speaking to Boris, he demonstrated some risks with this workflow. I opened #390 to apply his (and ChatGPT's) recommendations. |
|
I'm going to close this so we can address updates in PR #390 |
@boris-ning-usds pointed out that this pull_request_target trigger is a potential vulnerability in an open repo (see https://securitylab.github.com/resources/github-actions-preventing-pwn-requests/).
Let's merge this patch quickly and then discuss next week:
(1) Make sure everyone knows not to use this trigger in CDCGov in the future
(2) What should be the permanent fix? (Is this workflow essential?)