feat(ui): Update labels and tooltips for Sections#1317
Open
rogeruiz wants to merge 2 commits into
Open
Conversation
This missing `?` was causing issues on startup with a fresh DB on a new branch from `main`.
rogeruiz
added
dibbs-ecr-refiner
ux/ui
Contributor
🔒 Security Scan Results
|
| Severity | Total |
|---|---|
| 🟠 High | 8 |
📦 refiner-app
✅ No vulnerabilities found
📦 refiner-lambda
✅ No vulnerabilities found
📦 refiner-ops
| Severity | Count |
|---|---|
| 🟠 High | 8 |
View detailed results: Security tab
Last updated: 2026-06-03 19:48:09 UTC
rogeruiz
requested review from
fzhao99,
jakewheeler,
lina-roth and
robertmitchellv
as code owners
This was referenced Jun 4, 2026
rogeruiz
added a commit
that referenced
this pull request
Jun 4, 2026
This patch migrates the narrative field from a boolean type to a three-value enum across the API and client. This prepares the API and the client for the work being done for #1195. This work is independent of #1317 and #1318 but closely related to them. The latter needs to be safely integrated with this patch to ensure the changes don't conflict with one another.
9 tasks
rogeruiz
added a commit
that referenced
this pull request
Jun 4, 2026
This patch migrates the narrative field from a boolean type to a three-value enum across the API and client. This prepares the API and the client for the work being done for #1195. This work is independent of #1317 and #1318 but closely related to them. The latter needs to be safely integrated with this patch to ensure the changes don't conflict with one another.
9 tasks
fzhao99
approved these changes
Jun 5, 2026
Collaborator
Author
|
Gonna wait to do this merge until #1314 is merged in. I want to avoid any more conflicts on that PR while it's in good place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔀 PULL REQUEST
💡 Summary
This patch updates copy and labels for the Sections table to align better with
the Figma designs for the narrative reconstruction feature. The "Data handling
approach" column is now "Coded data", the "Narrative" column is now "Narrative
data", and the coded data toggle labels have been shorted from "Refine &
optimize" / "Preserve & retain all data" to "Refine" / "Keep original". Both
column tooltips have been rewritten to reflect the new terminology.
This PR is
text-only — it does not change any component structure, data model, or behavior.
The narrative toggle remains a Switch (dropdown conversion is in a later PR),
the narrative field remains a boolean, and no "Reconstruct" option is introduced
yet.
🔗 Related Issue
✅ Acceptance Criteria
Convert narrative data options to a drop-downReconstruct option appears in the drop-down when available for thatsection
Reconstruction option grayed out unless "refine" is selected for codeddata
If user has "reconstruct" for the narrative and tries to change codeddata to "keep original", error appears under the toggle
Default settings are "refine" for coded data and "keep original" fornarrative
Should retain pattern of blanking out excluded rows (not showing optionsfor coded data or refined data)
🧪 How to test
Verify the changes locally.
just dev upto bring up the application locallyheaders, tooltips, and toggle labels.
just client run lint fmt check test e2eℹ️ Additional Information
Note
The work related to #1195 will be applied in four different patches/PRs
starting with this one. Each patch will be as independent as possible and rely
only on prior patches as strictly necessary.