fix: minor design changes#1410
Merged
Merged
Conversation
Contributor
🔒 Security Scan Results
|
| Severity | Total |
|---|---|
| 🟠 High | 12 |
| 🟡 Medium | 3 |
📦 refiner-app
✅ No vulnerabilities found
📦 refiner-lambda
| Severity | Count |
|---|---|
| 🟠 High | 4 |
📦 refiner-ops
| Severity | Count |
|---|---|
| 🟠 High | 8 |
| 🟡 Medium | 3 |
View detailed results: Security tab
Last updated: 2026-06-22 19:29:55 UTC
fzhao99
commented
Jun 22, 2026
| await expect(page.getByText('COVID-19')).toBeVisible(); | ||
| const covidOption = page.getByRole('option', { name: 'COVID-19' }); | ||
| await covidOption.click(); | ||
| await expect(covidOption).not.toBeVisible(); |
Collaborator
Author
There was a problem hiding this comment.
was getting some test race condition flakiness on strict mode violations between the option and the rendered panel, so adding this extra check to make the tests more robust
fzhao99
commented
Jun 22, 2026
| <table className="w-full border-separate border-spacing-y-1"> | ||
| <caption className="text-left font-bold"> | ||
| {selectedCondition.display_name} | ||
| </caption> |
Collaborator
Author
There was a problem hiding this comment.
using <caption> here to have a more semantic way of grabbing the table in the e2e test.
fzhao99
requested review from
jakewheeler,
lina-roth,
robertmitchellv and
rogeruiz
as code owners
jakewheeler
reviewed
Jun 22, 2026
| onClose, | ||
| children, | ||
| position = 'center', | ||
| position = 'top', |
jakewheeler
reviewed
Jun 22, 2026
jakewheeler
requested changes
Jun 22, 2026
jakewheeler
left a comment
jakewheeler
left a comment
Collaborator
There was a problem hiding this comment.
Added one suggestion to fix the issue with the SVG element but otherwise looks good!
Co-authored-by: Jake Wheeler <jake.wheeler@skylight.digital>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔀 PULL REQUEST
💡 Summary
Fixes modal position of default modals and uses a new icon for the config build page.
✅ Acceptance Criteria
🧪 How to test
ℹ️ Additional Information