[NDH-678] Improve Test Assertions for Organization Tests#375
Merged
spopelka-dsac merged 17 commits intomainfrom Feb 9, 2026
Merged
[NDH-678] Improve Test Assertions for Organization Tests#375spopelka-dsac merged 17 commits intomainfrom
spopelka-dsac merged 17 commits intomainfrom
Conversation
…r organizations Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
IsaacMilarky
requested review from
rmillergv,
sachin-panayil,
spopelka-dsac and
wbprice
as code owners
spopelka-dsac
requested changes
Feb 3, 2026
Contributor
spopelka-dsac
left a comment
spopelka-dsac
left a comment
There was a problem hiding this comment.
A few minor tweaks
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Contributor
|
@IsaacMilarky Looks like there are failing tests |
Contributor
|
@IsaacMilarky Now there are other failing tests |
This was referenced Feb 9, 2026
* more response assertions * making the response urls more explicit
auto-merge was automatically disabled
February 9, 2026 19:13
Pull request was closed
auto-merge was automatically disabled
February 9, 2026 19:30
Pull request was closed
spopelka-dsac
approved these changes
Feb 9, 2026
Contributor
spopelka-dsac
left a comment
spopelka-dsac
left a comment
There was a problem hiding this comment.
merged some changes
Signed-off-by: Isaac Milarsky <isaac.milarsky@hhs.cms.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[NDH-678] Improve Test Assertions for Organization Tests
Jira Ticket #NDH-678
Problem
Right now, the organization list tests only test whether results are returned, not whether the filters are properly filtering results.
Solution
Add to the tests to make sure that all the returned data matches the filter parameters provided. Also make sure that returned data doesn't return non-matching data.
Result
Summary: