feat: use organisation scoped HCRC-lib#965
Conversation
|
FEDERATION-ROUTER branch is deployed to platta: https://events-graphql-federation-hobbies-pr965.dev.hel.ninja 🚀🚀🚀 |
|
FEDERATION-ROUTER branch is deployed to platta: https://events-graphql-federation-events-pr965.dev.hel.ninja 🚀🚀🚀 |
|
FEDERATION-ROUTER branch is deployed to platta: https://events-graphql-federation-sports-pr965.dev.hel.ninja 🚀🚀🚀 |
|
HARRASTUKSET-UI branch is deployed to platta: https://harrastukset-pr965.dev.hel.ninja 🚀🚀🚀 |
|
TAPAHTUMAT-UI branch is deployed to platta: https://tapahtumat-pr965.dev.hel.ninja 🚀🚀🚀 |
|
EVENTS-GRAPHQL-PROXY branch is deployed to platta: https://events-graphql-proxy-pr965.dev.hel.ninja 🚀🚀🚀 |
|
LIIKUNTA-UI branch is deployed to platta: https://liikunta-pr965.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://tapahtumat-pr965.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://liikunta-pr965.dev.hel.ninja 😆🎉🎉🎉 |
|
VENUE-GRAPHQL-PROXY branch is deployed to platta: https://venue-graphql-proxy-pr965.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://harrastukset-pr965.dev.hel.ninja 😆🎉🎉🎉 |
nikomakela
force-pushed
the
HCRC-191-org-scoped-hcrc
branch
from
db52bef to
eea37f6
Compare
|
FEDERATION-ROUTER branch is deployed to platta: https://events-graphql-federation-events-pr965.dev.hel.ninja 🚀🚀🚀 |
|
FEDERATION-ROUTER branch is deployed to platta: https://events-graphql-federation-hobbies-pr965.dev.hel.ninja 🚀🚀🚀 |
|
FEDERATION-ROUTER branch is deployed to platta: https://events-graphql-federation-sports-pr965.dev.hel.ninja 🚀🚀🚀 |
|
VENUE-GRAPHQL-PROXY branch is deployed to platta: https://venue-graphql-proxy-pr965.dev.hel.ninja 🚀🚀🚀 |
|
EVENTS-GRAPHQL-PROXY branch is deployed to platta: https://events-graphql-proxy-pr965.dev.hel.ninja 🚀🚀🚀 |
|
TAPAHTUMAT-UI branch is deployed to platta: https://tapahtumat-pr965.dev.hel.ninja 🚀🚀🚀 |
|
HARRASTUKSET-UI branch is deployed to platta: https://harrastukset-pr965.dev.hel.ninja 🚀🚀🚀 |
|
LIIKUNTA-UI branch is deployed to platta: https://liikunta-pr965.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://tapahtumat-pr965.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://harrastukset-pr965.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://liikunta-pr965.dev.hel.ninja 😆🎉🎉🎉 |
nikomakela
force-pushed
the
HCRC-191-org-scoped-hcrc
branch
from
eea37f6 to
f8ce6cc
Compare
|
FEDERATION-ROUTER branch is deployed to platta: https://events-graphql-federation-events-pr965.dev.hel.ninja 🚀🚀🚀 |
|
FEDERATION-ROUTER branch is deployed to platta: https://events-graphql-federation-hobbies-pr965.dev.hel.ninja 🚀🚀🚀 |
|
FEDERATION-ROUTER branch is deployed to platta: https://events-graphql-federation-sports-pr965.dev.hel.ninja 🚀🚀🚀 |
|
EVENTS-GRAPHQL-PROXY branch is deployed to platta: https://events-graphql-proxy-pr965.dev.hel.ninja 🚀🚀🚀 |
|
HARRASTUKSET-UI branch is deployed to platta: https://harrastukset-pr965.dev.hel.ninja 🚀🚀🚀 |
|
While this PR still has a release candidate version installed, I leave this as draft. |
HCRC-191. The 'react-helsinki-headless-cms' (HCRC-lib) has been published under city-of-helsinki organisation scope (https://www.npmjs.com/package/@city-of-helsinki/react-helsinki-headless-cms). This commit installs the new organisation scoped package and migrates all the related imports.
nikomakela
force-pushed
the
HCRC-191-org-scoped-hcrc
branch
from
f8ce6cc to
45b2fdc
Compare
|
|
|
|
FEDERATION-ROUTER branch is deployed to platta: https://events-graphql-federation-hobbies-pr965.dev.hel.ninja 🚀🚀🚀 |
|
FEDERATION-ROUTER branch is deployed to platta: https://events-graphql-federation-events-pr965.dev.hel.ninja 🚀🚀🚀 |
|
FEDERATION-ROUTER branch is deployed to platta: https://events-graphql-federation-sports-pr965.dev.hel.ninja 🚀🚀🚀 |
|
VENUE-GRAPHQL-PROXY branch is deployed to platta: https://venue-graphql-proxy-pr965.dev.hel.ninja 🚀🚀🚀 |
|
EVENTS-GRAPHQL-PROXY branch is deployed to platta: https://events-graphql-proxy-pr965.dev.hel.ninja 🚀🚀🚀 |
|
HARRASTUKSET-UI branch is deployed to platta: https://harrastukset-pr965.dev.hel.ninja 🚀🚀🚀 |
|
TAPAHTUMAT-UI branch is deployed to platta: https://tapahtumat-pr965.dev.hel.ninja 🚀🚀🚀 |
|
|
LIIKUNTA-UI branch is deployed to platta: https://liikunta-pr965.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://liikunta-pr965.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is success for https://harrastukset-pr965.dev.hel.ninja 😆🎉🎉🎉 |
TestCafe result is failed for https://tapahtumat-pr965.dev.hel.ninja 😿💢💥💥 |
1 similar comment
TestCafe result is failed for https://tapahtumat-pr965.dev.hel.ninja 😿💢💥💥 |
TestCafe result is success for https://tapahtumat-pr965.dev.hel.ninja 😆🎉🎉🎉 |
karisal-anders
left a comment
karisal-anders
left a comment
There was a problem hiding this comment.
Otherwise ok, but the peer dependencies are out-of-sync with react-helsinki-headless-cms:
$ yarn
➤ YN0000: ┌ Resolution step
➤ YN0060: │ @events-helsinki/components@workspace:packages/components
provides @apollo/client (pc4661) with version 3.13.8, which doesn't satisfy what
@city-of-helsinki/react-helsinki-headless-cms requests
➤ YN0000: │ Some peer dependencies are incorrectly met; run yarn
explain peer-requirements <hash> for details, where <hash> is the
six-letter p-prefixed code
$ yarn why @apollo/client
├─ @events-helsinki/components@workspace:packages/components [2e90d]
│ └─ @apollo/client@npm:3.13.8 [2ea0a] (via npm:^3.10.1 [2ea0a])
│
├─ @events-helsinki/components@workspace:packages/components
│ └─ @apollo/client@npm:3.13.8 [2ea0a] (via npm:^3.10.1 [2ea0a])
│
├─ events-helsinki@workspace:apps/events-helsinki
│ └─ @apollo/client@npm:3.13.8 [2ea0a] (via npm:^3.10.1 [2ea0a])
│
├─ hds-react@npm:4.8.1
│ └─ @apollo/client@npm:3.13.8 (via npm:^3.10.1)
│
├─ hds-react@npm:4.8.1 [e0bf5]
│ └─ @apollo/client@npm:3.13.8 [2ea0a] (via npm:^3.10.1 [2ea0a])
│
├─ hobbies-helsinki@workspace:apps/hobbies-helsinki
│ └─ @apollo/client@npm:3.13.8 [2ea0a] (via npm:^3.10.1 [2ea0a])
│
└─ sports-helsinki@workspace:apps/sports-helsinki
└─ @apollo/client@npm:3.13.8 [2ea0a] (via npm:^3.10.1 [2ea0a])
And react-helsinki-headless-cms v3.0.0 requests @apollo/client ^3.14.0.
Looks like it's working ok, there are no two different versions of @apollo/client installed, only v3.13.8 but that is not ^3.14.0. I don't think this is a blocker for merging, but just good to know that peer dependencies aren't really enforced and you might get something different than what is requested, as is the case here.
4 participants
HCRC-191.
The 'react-helsinki-headless-cms' (HCRC-lib) has been published under city-of-helsinki organisation scope
(https://www.npmjs.com/package/@city-of-helsinki/react-helsinki-headless-cms). This commit installs the new organisation scoped package and migrates all the related imports.
Related PR: City-of-Helsinki/react-helsinki-headless-cms#234