Skip to content

feat(profiling): pack column numbers for server-side unminification - #9501

Merged
szegedi merged 2 commits into
masterfrom
szegedi/update-profiler-5.17.0
Jul 23, 2026
Merged

feat(profiling): pack column numbers for server-side unminification#9501
szegedi merged 2 commits into
masterfrom
szegedi/update-profiler-5.17.0

Conversation

@szegedi

@szegedi szegedi commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Updates the profiler to 5.17.0. Also turns on emission of column information for profile frames that need server-side unminification.

Motivation

A customer reported issue where the lack of column information prevents correct unminification of profiles in the backend.

Jira: PROF-15467

szegedi and others added 2 commits July 23, 2026 12:19
Set columnNumbers: 'pack' on the wall profiler and pass 'pack' to the space
profiler's heap.profile call. pprof 5.17.0 packs the column into the line only
for frames whose source map is declared but missing (dd:has-missing-map-files) —
exactly the frames sent for server-side unminification — so this lets the
backend deobfuscate minified Node.js (e.g. Next.js server) frames, where the
column is the only discriminator between functions on a single generated line.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@szegedi
szegedi requested review from a team as code owners July 23, 2026 10:30
@szegedi
szegedi requested a review from IlyasShabi July 23, 2026 10:31
@dd-octo-sts

dd-octo-sts Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Overall package size

Self size: 7.48 MB
Deduped: 8.14 MB
No deduping: 8.14 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.3.2 | 124.41 kB | 440.65 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | dc-polyfill | 0.1.11 | 25.74 kB | 25.74 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@datadog-official

datadog-official Bot commented Jul 23, 2026

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🔄 Datadog retried 1 test - 1 passed on retry View in Datadog

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 98.44% (+0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 992d42b | Docs | Datadog PR Page | Give us feedback!

@pr-commenter

pr-commenter Bot commented Jul 23, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-07-23 10:40:03

Comparing candidate commit 992d42b in PR branch szegedi/update-profiler-5.17.0 with baseline commit ad76b96 in branch master.

📊 Benchmarking dashboard

Found 0 performance improvements and 0 performance regressions! Performance is the same for 2323 metrics, 35 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

Unstable benchmarks

These benchmarks have a confidence interval too wide to call a change; treat them as noise rather than signal.

scenario:appsec-appsec-enabled-24

  • unstable execution_time [-211048.234µs; +210252.201µs] or [-7.898%; +7.868%]

scenario:appsec-appsec-enabled-26

  • unstable execution_time [-229588.077µs; +228615.143µs] or [-9.002%; +8.963%]

scenario:appsec-appsec-enabled-with-attacks-24

  • unstable execution_time [-169.391ms; +162.000ms] or [-5.458%; +5.220%]

scenario:appsec-appsec-enabled-with-attacks-26

  • unstable execution_time [-186.398ms; +190.586ms] or [-6.397%; +6.541%]

scenario:appsec-control-20

  • unstable execution_time [-129.980ms; +118.895ms] or [-7.972%; +7.292%]

scenario:appsec-control-24

  • unstable execution_time [-115.196ms; +119.064ms] or [-9.253%; +9.564%]

scenario:appsec-control-26

  • unstable execution_time [-126663.239µs; +126790.172µs] or [-10.188%; +10.198%]

scenario:appsec-iast-no-vulnerability-iast-enabled-always-active-20

  • unstable execution_time [-16085.037µs; +14634.251µs] or [-6.348%; +5.775%]

scenario:appsec-iast-no-vulnerability-iast-enabled-default-config-20

  • unstable execution_time [-17782.352µs; +16303.019µs] or [-6.793%; +6.228%]

scenario:debugger-line-probe-with-snapshot-default-24

  • unstable cpu_user_time [-2010.855ms; +3217.948ms] or [-24.221%; +38.761%]
  • unstable execution_time [-2164.932ms; +3384.792ms] or [-24.008%; +37.536%]
  • unstable instructions [-17.1G instructions; +27.2G instructions] or [-25.197%; +40.205%]
  • unstable max_rss_usage [-8.460MB; +13.244MB] or [-5.394%; +8.445%]
  • unstable throughput [-877.958op/s; +568.574op/s] or [-23.970%; +15.523%]

scenario:debugger-line-probe-with-snapshot-minimal-24

  • unstable cpu_user_time [-1735.925ms; +566.240ms] or [-20.913%; +6.822%]
  • unstable execution_time [-1760.991ms; +579.307ms] or [-19.536%; +6.427%]
  • unstable instructions [-15.0G instructions; +4.8G instructions] or [-22.208%; +7.109%]
  • unstable throughput [-157.384op/s; +469.414op/s] or [-4.307%; +12.847%]

scenario:debugger-line-probe-with-snapshot-minimal-26

  • unstable cpu_user_time [-4623.001ms; +3077.536ms] or [-41.866%; +27.870%]
  • unstable execution_time [-4683.589ms; +3080.573ms] or [-39.798%; +26.177%]
  • unstable instructions [-41.0G instructions; +27.2G instructions] or [-43.942%; +29.169%]
  • unstable max_rss_usage [-14.771MB; +9.806MB] or [-9.019%; +5.987%]
  • unstable throughput [-611.840op/s; +922.796op/s] or [-20.754%; +31.302%]

scenario:debugger-line-probe-without-snapshot-26

  • unstable cpu_user_time [-2614.406ms; +4159.289ms] or [-27.451%; +43.673%]
  • unstable execution_time [-2614.920ms; +4162.577ms] or [-25.516%; +40.618%]
  • unstable instructions [-23.4G instructions; +37.2G instructions] or [-29.448%; +46.796%]
  • unstable max_rss_usage [-8.295MB; +13.969MB] or [-5.242%; +8.828%]
  • unstable throughput [-820.925op/s; +515.682op/s] or [-25.377%; +15.941%]

scenario:dogstatsd-with-tags-20

  • unstable cpu_user_time [-123.677ms; +455.291ms] or [-2.535%; +9.331%]
  • unstable execution_time [-124.072ms; +449.943ms] or [-2.506%; +9.086%]
  • unstable throughput [-159201.212op/s; +41373.937op/s] or [-9.399%; +2.443%]

scenario:plugin-graphql-long-with-depth-and-collapse-off-20

  • unstable max_rss_usage [-34.361MB; +37.236MB] or [-8.548%; +9.264%]

scenario:plugin-graphql-long-with-depth-off-20

  • unstable max_rss_usage [-6925.437KB; +8627.151KB] or [-5.305%; +6.608%]

scenario:plugin-graphql-long-with-depth-off-26

  • unstable max_rss_usage [-35.920MB; +25.747MB] or [-17.606%; +12.620%]

scenario:test-optimization-large-suite-20

  • unstable max_rss_usage [-4269.803KB; +3995.137KB] or [-5.439%; +5.090%]

@codecov

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@ad76b96). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #9501   +/-   ##
=========================================
  Coverage          ?   98.44%           
=========================================
  Files             ?      941           
  Lines             ?   126966           
  Branches          ?    10723           
=========================================
  Hits              ?   124997           
  Misses            ?     1969           
  Partials          ?        0           
Flag Coverage Δ
aiguard 57.50% <ø> (?)
aiguard-integration 56.33% <ø> (?)
apm-bucket-0 57.75% <ø> (?)
apm-bucket-1 64.04% <ø> (?)
apm-bucket-2 62.81% <ø> (?)
apm-bucket-3 60.17% <ø> (?)
apm-capabilities-tracing 64.61% <0.00%> (?)
apm-integrations-aerospike 56.75% <ø> (?)
apm-integrations-confluentinc-kafka-javascript 61.68% <ø> (?)
apm-integrations-couchbase 57.19% <ø> (?)
apm-integrations-http 62.82% <ø> (?)
apm-integrations-kafkajs 62.24% <ø> (?)
apm-integrations-next 59.29% <ø> (?)
apm-integrations-prisma 58.76% <ø> (?)
appsec 72.94% <ø> (?)
appsec-express_fastify_graphql 70.44% <ø> (?)
appsec-integration 51.51% <ø> (?)
appsec-kafka_ldapjs_lodash 64.02% <ø> (?)
appsec-mongodb-core_mongoose_mysql 67.74% <ø> (?)
appsec-next 57.61% <ø> (?)
appsec-node-serialize_passport_postgres 67.41% <ø> (?)
appsec-sourcing_stripe_template 65.76% <ø> (?)
debugger 64.95% <ø> (?)
instrumentations-bucket-0 51.84% <ø> (?)
instrumentations-bucket-1 60.34% <ø> (?)
instrumentations-bucket-10 62.14% <ø> (?)
instrumentations-bucket-11 51.75% <ø> (?)
instrumentations-bucket-12 52.32% <ø> (?)
instrumentations-bucket-13 51.86% <ø> (?)
instrumentations-bucket-2 53.75% <ø> (?)
instrumentations-bucket-3 59.34% <ø> (?)
instrumentations-bucket-4 52.41% <ø> (?)
instrumentations-bucket-5 57.65% <ø> (?)
instrumentations-bucket-6 60.86% <ø> (?)
instrumentations-bucket-7 58.53% <ø> (?)
instrumentations-bucket-8 59.67% <ø> (?)
instrumentations-bucket-9 61.66% <ø> (?)
instrumentations-instrumentation-couchbase 51.15% <ø> (?)
instrumentations-integration-esbuild 34.25% <ø> (?)
llmobs-ai_anthropic_bedrock 62.85% <ø> (?)
llmobs-bucket-1 61.65% <ø> (?)
llmobs-openai 62.79% <ø> (?)
llmobs-sdk 66.25% <ø> (?)
llmobs-vertex-ai 59.29% <ø> (?)
master-coverage 98.44% <100.00%> (?)
openfeature 56.21% <ø> (?)
openfeature-unit 53.51% <ø> (?)
platform-core_esbuild_instrumentations-misc 40.62% <ø> (?)
platform-integration 61.52% <ø> (?)
platform-shimmer_unit-guardrails_webpack 39.24% <ø> (?)
plugins-bucket-0 57.15% <ø> (?)
plugins-bucket-1 54.46% <ø> (?)
plugins-bucket-11 62.38% <ø> (?)
plugins-bucket-18 62.07% <ø> (?)
plugins-bucket-19 60.17% <ø> (?)
plugins-bucket-20 62.17% <ø> (?)
plugins-bucket-4 58.69% <ø> (?)
plugins-bullmq_cassandra_cookie 61.86% <ø> (?)
plugins-cookie-parser_crypto_dd-trace-api 56.85% <ø> (?)
plugins-fetch_fs_generic-pool 58.89% <ø> (?)
plugins-google-cloud-pubsub_grpc_handlebars 64.80% <ø> (?)
plugins-hapi_hono_ioredis 60.34% <ø> (?)
plugins-jest_knex_langgraph 55.71% <ø> (?)
plugins-ldapjs_light-my-request_limitd-client 58.62% <ø> (?)
plugins-lodash_mariadb_memcached 58.12% <ø> (?)
plugins-moleculer_mongodb_mongodb-core 62.03% <ø> (?)
plugins-mongoose_multer_mysql 59.13% <ø> (?)
plugins-mysql2_nats_node-serialize 60.83% <ø> (?)
plugins-opensearch_passport-http_pino 59.66% <ø> (?)
plugins-postgres_process_pug 58.39% <ø> (?)
plugins-redis_router_sequelize 62.16% <ø> (?)
plugins-test-and-upstream-rhea_undici_url 61.74% <ø> (?)
plugins-valkey_vm_winston 58.13% <ø> (?)
plugins-ws 59.72% <ø> (?)
profiling 62.25% <100.00%> (?)
serverless-aws-sdk-aws-sdk 55.15% <ø> (?)
serverless-aws-sdk-bedrockruntime 54.86% <ø> (?)
serverless-aws-sdk-client 56.54% <ø> (?)
serverless-aws-sdk-dynamodb 55.77% <ø> (?)
serverless-aws-sdk-eventbridge 49.48% <ø> (?)
serverless-aws-sdk-kinesis 59.45% <ø> (?)
serverless-aws-sdk-lambda 57.50% <ø> (?)
serverless-aws-sdk-s3 55.71% <ø> (?)
serverless-aws-sdk-serverless-peer-service 59.85% <ø> (?)
serverless-aws-sdk-sns 60.24% <ø> (?)
serverless-aws-sdk-sqs 60.68% <ø> (?)
serverless-aws-sdk-stepfunctions 55.69% <ø> (?)
serverless-aws-sdk-util 51.59% <ø> (?)
serverless-bucket-0 54.35% <ø> (?)
serverless-bucket-1 59.37% <ø> (?)
test-optimization-cucumber 72.01% <ø> (?)
test-optimization-cypress 65.89% <ø> (?)
test-optimization-jest 73.32% <ø> (?)
test-optimization-mocha 73.58% <ø> (?)
test-optimization-playwright-playwright-atr 60.27% <ø> (?)
test-optimization-playwright-playwright-efd 60.66% <ø> (?)
test-optimization-playwright-playwright-final-status 60.63% <ø> (?)
test-optimization-playwright-playwright-impacted-tests 60.36% <ø> (?)
test-optimization-playwright-playwright-reporting 61.66% <ø> (?)
test-optimization-playwright-playwright-test-management 61.33% <ø> (?)
test-optimization-playwright-playwright-test-span 60.58% <ø> (?)
test-optimization-selenium 60.14% <ø> (?)
test-optimization-testopt 58.58% <ø> (?)
test-optimization-vitest 70.36% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@szegedi
szegedi merged commit 0bbf75c into master Jul 23, 2026
662 of 663 checks passed
@szegedi
szegedi deleted the szegedi/update-profiler-5.17.0 branch July 23, 2026 10:56
This was referenced Jul 23, 2026
szegedi added a commit that referenced this pull request Jul 23, 2026
…9501)

* feat(profiling): pack column numbers for server-side unminification

Updates profiler to 5.17.0, and then sets columnNumbers: 'pack' on the wall profiler and pass 'pack' to the space profiler's heap.profile call. pprof 5.17.0 packs the column into the line only for frames whose source map is declared but missing (dd:has-missing-map-files) — exactly the frames sent for server-side unminification — so this lets the
backend deobfuscate minified Node.js (e.g. Next.js server) frames, where the column is the only discriminator between functions on a single generated line.
szegedi added a commit that referenced this pull request Jul 23, 2026
…9501)

* feat(profiling): pack column numbers for server-side unminification

Updates profiler to 5.17.0, and then sets columnNumbers: 'pack' on the wall profiler and pass 'pack' to the space profiler's heap.profile call. pprof 5.17.0 packs the column into the line only for frames whose source map is declared but missing (dd:has-missing-map-files) — exactly the frames sent for server-side unminification — so this lets the
backend deobfuscate minified Node.js (e.g. Next.js server) frames, where the column is the only discriminator between functions on a single generated line.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants