OTel Metric templates are direct protobuf types#1350
Merged
Conversation
Collaborator
Author
Datadog Summary✅ Code Quality ✅ Code Security ✅ Dependencies Was this helpful? Give us feedback! |
blt
force-pushed
the
blt/optimization_passes_for_otel_metrics_payload_generation
branch
from
935e384 to
49549ec
Compare
blt
force-pushed
the
blt/otel_metric_templates_are_direct_protobuf_types
branch
2 times, most recently
from
9a171ae to
ddc5dfa
Compare
blt
force-pushed
the
blt/optimization_passes_for_otel_metrics_payload_generation
branch
2 times, most recently
from
05fca81 to
f7db081
Compare
blt
force-pushed
the
blt/otel_metric_templates_are_direct_protobuf_types
branch
2 times, most recently
from
89e2f4a to
e87c0f3
Compare
blt
force-pushed
the
blt/optimization_passes_for_otel_metrics_payload_generation
branch
from
f7db081 to
1134de9
Compare
blt
force-pushed
the
blt/otel_metric_templates_are_direct_protobuf_types
branch
from
e87c0f3 to
62810d6
Compare
blt
force-pushed
the
blt/optimization_passes_for_otel_metrics_payload_generation
branch
2 times, most recently
from
3f73728 to
c1554c2
Compare
blt
force-pushed
the
blt/otel_metric_templates_are_direct_protobuf_types
branch
from
62810d6 to
0c38025
Compare
blt
force-pushed
the
blt/optimization_passes_for_otel_metrics_payload_generation
branch
from
c1554c2 to
b705974
Compare
blt
force-pushed
the
blt/otel_metric_templates_are_direct_protobuf_types
branch
from
0c38025 to
2ba374d
Compare
goxberry
approved these changes
May 13, 2025
blt
force-pushed
the
blt/optimization_passes_for_otel_metrics_payload_generation
branch
from
b705974 to
c6a82e1
Compare
blt
force-pushed
the
blt/otel_metric_templates_are_direct_protobuf_types
branch
from
2ba374d to
3b2bf3e
Compare
blt
force-pushed
the
blt/optimization_passes_for_otel_metrics_payload_generation
branch
from
c6a82e1 to
f5e7ff3
Compare
blt
force-pushed
the
blt/otel_metric_templates_are_direct_protobuf_types
branch
from
3b2bf3e to
619f189
Compare
blt
force-pushed
the
blt/otel_metric_templates_are_direct_protobuf_types
branch
from
619f189 to
87fa48b
Compare
blt
force-pushed
the
blt/optimization_passes_for_otel_metrics_payload_generation
branch
from
f5e7ff3 to
60f66df
Compare
blt
force-pushed
the
blt/otel_metric_templates_are_direct_protobuf_types
branch
from
87fa48b to
f24978e
Compare
blt
force-pushed
the
blt/optimization_passes_for_otel_metrics_payload_generation
branch
from
60f66df to
9b3a931
Compare
blt
force-pushed
the
blt/otel_metric_templates_are_direct_protobuf_types
branch
from
30286ee to
8f095f4
Compare
blt
force-pushed
the
blt/optimization_passes_for_otel_metrics_payload_generation
branch
from
0570d75 to
986d6dc
Compare
blt
force-pushed
the
blt/otel_metric_templates_are_direct_protobuf_types
branch
from
8f095f4 to
9a1e8e2
Compare
blt
force-pushed
the
blt/optimization_passes_for_otel_metrics_payload_generation
branch
from
986d6dc to
810c9be
Compare
blt
force-pushed
the
blt/otel_metric_templates_are_direct_protobuf_types
branch
from
9a1e8e2 to
585b425
Compare
blt
force-pushed
the
blt/optimization_passes_for_otel_metrics_payload_generation
branch
from
810c9be to
533936d
Compare
blt
force-pushed
the
blt/otel_metric_templates_are_direct_protobuf_types
branch
from
585b425 to
8682b76
Compare
blt
force-pushed
the
blt/optimization_passes_for_otel_metrics_payload_generation
branch
from
533936d to
cc26354
Compare
blt
force-pushed
the
blt/otel_metric_templates_are_direct_protobuf_types
branch
from
8682b76 to
0486539
Compare
blt
force-pushed
the
blt/optimization_passes_for_otel_metrics_payload_generation
branch
from
cc26354 to
dbb3152
Compare
blt
force-pushed
the
blt/otel_metric_templates_are_direct_protobuf_types
branch
from
0486539 to
1d248ee
Compare
blt
force-pushed
the
blt/optimization_passes_for_otel_metrics_payload_generation
branch
2 times, most recently
from
40ad9a2 to
68c97ab
Compare
blt
force-pushed
the
blt/otel_metric_templates_are_direct_protobuf_types
branch
from
1d248ee to
88cb8ba
Compare
blt
changed the base branch from
blt/optimization_passes_for_otel_metrics_payload_generation
to
graphite-base/1350
This commit removes the intermediary template types in favor of producing directly into serializable types. REF SMPTNG-569 Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
I neglected to pop the too-big resource_metrics off the request once we detected that we were past the limit. Fixed. Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
blt
force-pushed
the
blt/otel_metric_templates_are_direct_protobuf_types
branch
from
88cb8ba to
e3a8386
Compare
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
blt
force-pushed
the
blt/otel_metric_templates_are_direct_protobuf_types
branch
from
e3a8386 to
867ab2b
Compare
Collaborator
Author
This was referenced May 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This commit removes the intermediary template types in favor of producing
directly into serializable types.
Motivation
REF SMPTNG-569