Conversation
This was referenced May 15, 2025
Collaborator
Author
blt
force-pushed
the
blt/create_a_sizedgenerator_for_use_in_otel_metrics
branch
from
5f62df5 to
7390b52
Compare
blt
force-pushed
the
blt/update_metrics_generation_such_that_timestamps_sums_are_updated
branch
from
9c9fc4b to
e5c8b40
Compare
blt
force-pushed
the
blt/create_a_sizedgenerator_for_use_in_otel_metrics
branch
from
7390b52 to
19b629a
Compare
blt
force-pushed
the
blt/update_metrics_generation_such_that_timestamps_sums_are_updated
branch
from
e5c8b40 to
590f3a0
Compare
blt
force-pushed
the
blt/create_a_sizedgenerator_for_use_in_otel_metrics
branch
from
19b629a to
fb7a2b1
Compare
blt
force-pushed
the
blt/update_metrics_generation_such_that_timestamps_sums_are_updated
branch
from
590f3a0 to
c580f01
Compare
blt
force-pushed
the
blt/create_a_sizedgenerator_for_use_in_otel_metrics
branch
2 times, most recently
from
62c1fbf to
7fe5e85
Compare
blt
force-pushed
the
blt/update_metrics_generation_such_that_timestamps_sums_are_updated
branch
from
c580f01 to
baad21d
Compare
blt
changed the base branch from
blt/create_a_sizedgenerator_for_use_in_otel_metrics
to
graphite-base/1356
blt
force-pushed
the
blt/update_metrics_generation_such_that_timestamps_sums_are_updated
branch
from
baad21d to
bee6f6b
Compare
blt
force-pushed
the
blt/update_metrics_generation_such_that_timestamps_sums_are_updated
branch
from
bee6f6b to
15583ed
Compare
This commit modifies the OpentelemetryMetrics generation of metrics such that timestamps are always increasing -- with a loop around once the block is exhausted -- and also accumulating sums do in fact accumulate, until wrap-around. REF SMPTNG-659 Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
This commit changes how points are randomly created, being zero valued. This means that the Opentelemetry generator is responsible for setting point values as they are generated, which is ideal. Allows us to prove that monotonic increases happen and we reduce the computation burden on the pool. This is effectively what we were doing already -- the underlying point value was entirely discarded. Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
blt
force-pushed
the
blt/update_metrics_generation_such_that_timestamps_sums_are_updated
branch
from
15583ed to
9ca1fbd
Compare
scottopell
approved these changes
May 19, 2025
Collaborator
Author
blt
deleted the
blt/update_metrics_generation_such_that_timestamps_sums_are_updated
branch
This was referenced May 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This commit modifies the OpentelemetryMetrics generation of metrics
such that timestamps are always increasing -- with a loop around
once the block is exhausted -- and also accumulating sums do in
fact accumulate, until wrap-around.
Motivation
REF SMPTNG-659