Optimization passes for Otel metrics payload generation#1342
Merged
Conversation
This was referenced May 1, 2025
Collaborator
Author
blt
force-pushed
the
blt/optimization_passes_for_otel_metrics_payload_generation
branch
from
1fdd500 to
d0bd6ac
Compare
scottopell
approved these changes
May 2, 2025
blt
force-pushed
the
blt/introduce_tag_generator_into_otel_metrics_payload
branch
from
7fb6ccc to
290b8f4
Compare
blt
force-pushed
the
blt/optimization_passes_for_otel_metrics_payload_generation
branch
from
a08d215 to
19ce922
Compare
This was referenced May 8, 2025
Closed
blt
force-pushed
the
blt/optimization_passes_for_otel_metrics_payload_generation
branch
from
19ce922 to
cc7a0fc
Compare
blt
force-pushed
the
blt/introduce_tag_generator_into_otel_metrics_payload
branch
from
290b8f4 to
f0996d7
Compare
blt
force-pushed
the
blt/optimization_passes_for_otel_metrics_payload_generation
branch
2 times, most recently
from
462e549 to
6820721
Compare
blt
force-pushed
the
blt/introduce_tag_generator_into_otel_metrics_payload
branch
from
f0996d7 to
65e9d76
Compare
blt
force-pushed
the
blt/optimization_passes_for_otel_metrics_payload_generation
branch
from
6820721 to
9036751
Compare
blt
force-pushed
the
blt/introduce_tag_generator_into_otel_metrics_payload
branch
from
65e9d76 to
f9c8702
Compare
blt
force-pushed
the
blt/optimization_passes_for_otel_metrics_payload_generation
branch
from
2eae615 to
935e384
Compare
This was referenced May 12, 2025
blt
force-pushed
the
blt/introduce_tag_generator_into_otel_metrics_payload
branch
from
f9c8702 to
0e5e725
Compare
blt
force-pushed
the
blt/introduce_tag_generator_into_otel_metrics_payload
branch
from
38c88c5 to
316ebaf
Compare
blt
force-pushed
the
blt/optimization_passes_for_otel_metrics_payload_generation
branch
from
0570d75 to
986d6dc
Compare
blt
force-pushed
the
blt/introduce_tag_generator_into_otel_metrics_payload
branch
from
316ebaf to
c2ded89
Compare
blt
force-pushed
the
blt/optimization_passes_for_otel_metrics_payload_generation
branch
from
986d6dc to
810c9be
Compare
blt
force-pushed
the
blt/introduce_tag_generator_into_otel_metrics_payload
branch
from
c2ded89 to
c2a5afe
Compare
blt
force-pushed
the
blt/optimization_passes_for_otel_metrics_payload_generation
branch
from
810c9be to
533936d
Compare
scottopell
reviewed
May 15, 2025
| codegen-units = 1 # Increases compile time but improves optimization alternatives. | ||
| opt-level = 3 # Optimize with 'all' optimization flipped on. May produce larger binaries than 's' or 'z'. | ||
| panic = "abort" | ||
| debug = false |
Contributor
There was a problem hiding this comment.
do we really want to disable debug? Doesn't this come into play for symbolizing the stack on panic?
Collaborator
Author
There was a problem hiding this comment.
Ah this is me actually just expressing what the default is. I'll fix this up-stack. You make a good point.
blt
force-pushed
the
blt/optimization_passes_for_otel_metrics_payload_generation
branch
from
533936d to
cc26354
Compare
blt
force-pushed
the
blt/introduce_tag_generator_into_otel_metrics_payload
branch
from
c2a5afe to
44ee1a3
Compare
blt
force-pushed
the
blt/introduce_tag_generator_into_otel_metrics_payload
branch
2 times, most recently
from
e610b10 to
11841e5
Compare
blt
force-pushed
the
blt/optimization_passes_for_otel_metrics_payload_generation
branch
from
cc26354 to
dbb3152
Compare
blt
changed the base branch from
blt/introduce_tag_generator_into_otel_metrics_payload
to
graphite-base/1342
This commit bundles a small number of optimization passes on the payload generation code. We're clocking in at 100Mb/s after this work -- measured by opentelemetry_metric_all/1000000 -- up from 54Mb/s so it's something. Still noticably slow at high entropy. SMPTNG-659 Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
blt
force-pushed
the
blt/optimization_passes_for_otel_metrics_payload_generation
branch
from
dbb3152 to
40ad9a2
Compare
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
blt
force-pushed
the
blt/optimization_passes_for_otel_metrics_payload_generation
branch
from
40ad9a2 to
68c97ab
Compare
Collaborator
Author
blt
deleted the
blt/optimization_passes_for_otel_metrics_payload_generation
branch
This was referenced May 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This commit bundles a small number of optimization passes on the payload generation code. We're clocking in at 100Mb/s after this work -- measured by opentelemetry_metric_all/1000000 -- up from 54Mb/s so it's something. Still noticably slow at high entropy.
Motivation
SMPTNG-659