enhancement(antithesis): Move antithesis/deploy to scenarios/general by blt · Pull Request #1890 · DataDog/saluki

blt · 2026-06-18T21:23:55Z

Summary

I am slowly developing a House Style for test/antithesis. The next PR in this stack as of this writing -- #1891 -- introduces a new scenario with a new topology. Organizationally this means we have a 'general' scenario in this project already and my intention is to make a new scenario to differentially test Datadog Agent and ADP. There will be several PRs in a chain to reach a satisfying spot with that work.

There's no functional change in this PR, just some code movement.

Change Type

Bug fix
New feature
Non-functional (chore, refactoring, docs)
Performance

How did you test this PR?

References

blt · 2026-06-18T21:24:15Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

pr-commenter · 2026-06-18T21:32:01Z

Binary Size Analysis (Agent Data Plane)

Baseline: 9c1abde · Comparison: b43c958 · diff
Analysis Configuration: stripped binaries · Pass/Fail Threshold: +5%
Sizes: 40.37 MiB (baseline) vs 40.37 MiB (comparison)
Size Change: -8 B (-0.00%)

✅ Binary size difference within threshold

Changes by Module

Module	File Size	Symbols
`anon.c332a4a573d0a9a1bf7c71b0a1f57672.1.llvm.12576821623472313372`	-130 B	1
`anon.c332a4a573d0a9a1bf7c71b0a1f57672.1.llvm.6247713684285214693`	+129 B	1
`anon.c332a4a573d0a9a1bf7c71b0a1f57672.4.llvm.12576821623472313372`	-115 B	1
`anon.c332a4a573d0a9a1bf7c71b0a1f57672.4.llvm.6247713684285214693`	+114 B	1
`anon.c332a4a573d0a9a1bf7c71b0a1f57672.3.llvm.12576821623472313372`	-109 B	1
`anon.c332a4a573d0a9a1bf7c71b0a1f57672.3.llvm.6247713684285214693`	+108 B	1
`anon.c332a4a573d0a9a1bf7c71b0a1f57672.0.llvm.12576821623472313372`	-97 B	1
`anon.c332a4a573d0a9a1bf7c71b0a1f57672.0.llvm.6247713684285214693`	+96 B	1
`anon.c332a4a573d0a9a1bf7c71b0a1f57672.2.llvm.12576821623472313372`	-95 B	1
`anon.c332a4a573d0a9a1bf7c71b0a1f57672.2.llvm.6247713684285214693`	+94 B	1
`[Unmapped]`	-3 B	1

Detailed Symbol Changes

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [NEW]    +129  [NEW]     +40    anon.c332a4a573d0a9a1bf7c71b0a1f57672.1.llvm.6247713684285214693
  [NEW]    +114  [NEW]     +25    anon.c332a4a573d0a9a1bf7c71b0a1f57672.4.llvm.6247713684285214693
  [NEW]    +108  [NEW]     +19    anon.c332a4a573d0a9a1bf7c71b0a1f57672.3.llvm.6247713684285214693
  [NEW]     +96  [NEW]      +7    anon.c332a4a573d0a9a1bf7c71b0a1f57672.0.llvm.6247713684285214693
  [NEW]     +94  [NEW]      +5    anon.c332a4a573d0a9a1bf7c71b0a1f57672.2.llvm.6247713684285214693
  -0.0%      -3  [ = ]       0    [Unmapped]
  [DEL]     -95  [DEL]      -5    anon.c332a4a573d0a9a1bf7c71b0a1f57672.2.llvm.12576821623472313372
  [DEL]     -97  [DEL]      -7    anon.c332a4a573d0a9a1bf7c71b0a1f57672.0.llvm.12576821623472313372
  [DEL]    -109  [DEL]     -19    anon.c332a4a573d0a9a1bf7c71b0a1f57672.3.llvm.12576821623472313372
  [DEL]    -115  [DEL]     -25    anon.c332a4a573d0a9a1bf7c71b0a1f57672.4.llvm.12576821623472313372
  [DEL]    -130  [DEL]     -40    anon.c332a4a573d0a9a1bf7c71b0a1f57672.1.llvm.12576821623472313372
  -0.0%      -8  [ = ]       0    TOTAL

pr-commenter · 2026-06-18T22:18:02Z

Regression Detector (Agent Data Plane)

Run ID: 7d2b6b3d-2f18-4f8a-a3a8-91c28a543e69
Baseline: 9c1abdeb · Comparison: b43c9585 · diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment (35)

Experiments configured erratic: true are tagged (ignored) and skipped when determining which experiments regressed or improved. Experiments which are detected as erratic at runtime are tagged (erratic) to flag that the run's sample dispersion was high, but their regression / improvement signal still counts.

experiment	goal	Δ mean %	links
dsd_uds_512kb_3k_contexts_cpu (erratic)	cpu	⚪ +12.74	metrics profiles logs
otlp_ingest_logs_5mb_cpu (ignored)	cpu	⚪ +1.81	metrics profiles logs
otlp_ingest_metrics_5mb_memory	memory	⚪ +1.48	metrics profiles logs
dsd_uds_500mb_3k_contexts_cpu (erratic)	cpu	⚪ +1.25	metrics profiles logs
otlp_ingest_traces_ottl_transform_5mb_cpu (erratic)	cpu	⚪ +0.92	metrics profiles logs
otlp_ingest_traces_ottl_filtering_5mb_cpu (erratic)	cpu	⚪ +0.91	metrics profiles logs
dsd_uds_500mb_3k_contexts_memory	memory	⚪ +0.53	metrics profiles logs
dsd_uds_10mb_3k_contexts_memory	memory	⚪ +0.25	metrics profiles logs
quality_gates_rss_dsd_ultraheavy	memory	⚪ +0.23	metrics profiles logs
dsd_uds_100mb_3k_contexts_memory	memory	⚪ +0.22	metrics profiles logs
otlp_ingest_traces_ottl_transform_5mb_memory	memory	⚪ +0.14	metrics profiles logs
otlp_ingest_traces_5mb_throughput	throughput	⚪ -0.13	metrics profiles logs
otlp_ingest_traces_ottl_filtering_5mb_memory	memory	⚪ +0.12	metrics profiles logs
quality_gates_rss_dsd_low	memory	⚪ +0.11	metrics profiles logs
dsd_uds_512kb_3k_contexts_memory	memory	⚪ +0.09	metrics profiles logs
otlp_ingest_traces_ottl_transform_5mb_throughput	throughput	⚪ -0.07	metrics profiles logs
dsd_uds_100mb_3k_contexts_throughput	throughput	⚪ -0.01	metrics profiles logs
dsd_uds_1mb_3k_contexts_throughput	throughput	⚪ -0.00	metrics profiles logs
dsd_uds_512kb_3k_contexts_throughput	throughput	⚪ +0.00	metrics profiles logs
dsd_uds_10mb_3k_contexts_throughput	throughput	⚪ +0.01	metrics profiles logs
otlp_ingest_logs_5mb_throughput (ignored)	throughput	⚪ +0.02	metrics profiles logs
otlp_ingest_metrics_5mb_throughput	throughput	⚪ +0.02	metrics profiles logs
otlp_ingest_traces_5mb_memory	memory	⚪ -0.07	metrics profiles logs
quality_gates_rss_dsd_medium	memory	⚪ -0.09	metrics profiles logs
quality_gates_rss_dsd_heavy	memory	⚪ -0.11	metrics profiles logs
dsd_uds_1mb_3k_contexts_memory	memory	⚪ -0.19	metrics profiles logs
dsd_uds_100mb_3k_contexts_cpu (erratic)	cpu	⚪ -0.23	metrics profiles logs
otlp_ingest_metrics_5mb_cpu (erratic)	cpu	⚪ -0.53	metrics profiles logs
quality_gates_rss_idle	memory	⚪ -0.57	metrics profiles logs
otlp_ingest_traces_5mb_cpu (erratic)	cpu	⚪ -0.80	metrics profiles logs
otlp_ingest_traces_ottl_filtering_5mb_throughput	throughput	⚪ +0.84	metrics profiles logs
dsd_uds_10mb_3k_contexts_cpu (erratic)	cpu	⚪ -1.20	metrics profiles logs
dsd_uds_500mb_3k_contexts_throughput	throughput	⚪ +1.56	metrics profiles logs
dsd_uds_1mb_3k_contexts_cpu (erratic)	cpu	🟢 -5.43	metrics profiles logs
otlp_ingest_logs_5mb_memory (ignored)	memory	⚪ -6.80	metrics profiles logs

Bounds Checks: ✅ Passed (5)

experiment	check	replicates	observed	links
quality_gates_rss_dsd_heavy	memory_usage	10/10	✅ 130 MiB ≤ 140 MiB	metrics profiles logs
quality_gates_rss_dsd_low	memory_usage	10/10	✅ 42.5 MiB ≤ 50 MiB	metrics profiles logs
quality_gates_rss_dsd_medium	memory_usage	10/10	✅ 66.2 MiB ≤ 75 MiB	metrics profiles logs
quality_gates_rss_dsd_ultraheavy	memory_usage	10/10	✅ 191 MiB ≤ 200 MiB	metrics profiles logs
quality_gates_rss_idle	memory_usage	10/10	✅ 28.2 MiB ≤ 40 MiB	metrics profiles logs

Explanation

A change is flagged as a regression when |Δ mean %| > 5.00% in the regressing direction for its optimization goal AND SMP marks the experiment as a regression (is_regression: true). Improvements use the matching criteria for the improving direction. Experiments configured erratic: true (tagged (ignored)) are skipped outright; experiments detected as erratic at runtime (tagged (erratic)) still count, since that flag describes sample dispersion rather than directional certainty. The Δ mean % cell is colored accordingly: 🟢 = improvement, 🔴 = regression, ⚪ = neutral. Reduction in CPU or memory is an improvement; reduction in ingress throughput is a regression.

Copilot

Pull request overview

This PR restructures the Antithesis test configuration by moving the former test/antithesis/deploy layout into a scenario-oriented directory (test/antithesis/scenarios/general) and updating references across docs and build tooling to match.

Changes:

Introduces the antithesis-scenario-general crate and scenario-local Docker/compose scaffolding under test/antithesis/scenarios/general/.
Updates Antithesis documentation/scratchbook references to point at the new scenario paths.
Adjusts workspace/build plumbing (workspace members, shared deps, Makefile Antithesis config dir) to include and use the new scenario.

Reviewed changes

Copilot reviewed 15 out of 21 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
test/antithesis/scratchbook/w-property-intake.md	Updates hostname/config path reference to the new scenario location.
test/antithesis/scratchbook/sut-analysis.md	Updates Dockerfile path reference to the new scenario location.
test/antithesis/scratchbook/properties/adp-stays-alive.md	Updates deploy-path references to scenario-path references.
test/antithesis/scratchbook/existing-assertions.md	Updates driver binary path references from harness to scenario crate; updates narrative text.
test/antithesis/scenarios/general/workload/test/v1/.gitkeep	Adds placeholder to keep the test template directory in the repo.
test/antithesis/scenarios/general/workload/setup-complete.sh	Adds setup-complete emission helper script for Antithesis workload container.
test/antithesis/scenarios/general/workload/entrypoint.sh	Adds workload entrypoint that emits setup-complete then idles for test commands.
test/antithesis/scenarios/general/src/bin/parallel_driver_sketchburst.rs	Renames socket env var used by the driver to the scenario’s convention.
test/antithesis/scenarios/general/src/bin/parallel_driver_send_dogstatsd.rs	Renames socket env var used by the driver to the scenario’s convention.
test/antithesis/scenarios/general/Dockerfile	Adds scenario-local Dockerfile; splits cargo builds by package and updates copy paths.
test/antithesis/scenarios/general/docker-compose.yaml	Points compose at the scenario Dockerfile and updates env var naming for workload.
test/antithesis/scenarios/general/Cargo.toml	Adds new scenario crate package manifest.
test/antithesis/scenarios/general/adp/entrypoint.sh	Adds ADP boot wrapper that waits for per-timeline config before exec’ing ADP.
test/antithesis/scenarios/general/adp/datadog.yaml	Adds minimal baked-in ADP config for the scenario image.
test/antithesis/intake/Cargo.toml	Switches `headers`/`mime` dependencies to workspace-managed versions.
test/antithesis/harness/src/lib.rs	Updates crate-level rustdoc summary.
test/antithesis/harness/src/bin/eventually_adp_alive.rs	Renames socket env var consumed by the liveness checker.
test/antithesis/AGENTS.md	Updates guidance and directory layout docs for the new scenario structure.
Makefile	Updates `ANTITHESIS_CONFIG_DIR` to the new scenario directory.
Cargo.toml	Adds the new scenario crate to workspace members and adds `mime` to workspace deps.
Cargo.lock	Adds lockfile entries for the new scenario crate.

Comments suppressed due to low confidence (1)

test/antithesis/scenarios/general/docker-compose.yaml:61

PR description says there is "no functional change", but renaming the workload socket env var from DSD_SOCKET to ADP_DOGSTATSD_SOCKET is an externally visible interface change (it can break local overrides and any existing run configs). Either keep the original env var name, support both names for a transition, or update the PR description to call this out explicitly.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 12 out of 18 changed files in this pull request and generated no new comments.

Copilot

Pull request overview

Copilot reviewed 12 out of 18 changed files in this pull request and generated no new comments.

Copilot

Pull request overview

Copilot reviewed 11 out of 17 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

test/antithesis/scenarios/general/docker-compose.yaml:61

The workload container sets ADP_DOGSTATSD_SOCKET, but first_sample_config (in test/antithesis/harness/src/bin/first_sample_config/main.rs) reads DOGSTATSD_SOCKET to decide what socket path to write into the sampled datadog.yaml. If the socket path is ever changed via env, drivers and the sampled ADP config can diverge. Consider exporting both variables here to keep the config sampler and the drivers in sync.

Copilot

Pull request overview

Copilot reviewed 11 out of 17 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

test/antithesis/scenarios/general/docker-compose.yaml:61

PR description says there's no functional change, but this PR renames the DogStatsD socket environment variable from DSD_SOCKET to ADP_DOGSTATSD_SOCKET (also reflected in the Rust CLI env settings). That changes the externally visible interface for anyone running the binaries outside docker-compose; either document it in the PR description/release notes or keep backward compatibility (e.g., accept both env vars).

blt · 2026-06-25T17:52:37Z

Merge activity

Jun 25, 5:52 PM UTC: A user started a stack merge that includes this pull request via Graphite.
Jun 25, 5:53 PM UTC: @blt merged this pull request with Graphite.

…1890) ## Summary I am slowly developing a House Style for `test/antithesis`. The next PR in this stack as of this writing -- #1891 -- introduces a new scenario with a new topology. Organizationally this means we have a 'general' scenario in this project already and my intention is to make a new scenario to differentially test Datadog Agent and ADP. There will be several PRs in a chain to reach a satisfying spot with that work. There's no functional change in this PR, just some code movement.  ## Change Type - [ ] Bug fix - [ ] New feature - [ ] Non-functional (chore, refactoring, docs) - [ ] Performance ## How did you test this PR?  ## References    2b0cad1

…1890) I am slowly developing a House Style for `test/antithesis`. The next PR in this stack as of this writing -- #1891 -- introduces a new scenario with a new topology. Organizationally this means we have a 'general' scenario in this project already and my intention is to make a new scenario to differentially test Datadog Agent and ADP. There will be several PRs in a chain to reach a satisfying spot with that work. There's no functional change in this PR, just some code movement.  - [ ] Bug fix - [ ] New feature - [ ] Non-functional (chore, refactoring, docs) - [ ] Performance

dd-octo-sts Bot added the area/test All things testing: unit/integration, correctness, SMP regression, etc. label Jun 18, 2026

This was referenced Jun 18, 2026

enhancement(antithesis): Introduce rig intake API #1826

Merged

chore(antithesis): Differential comparison between ADP and Datadog Agent context egress #1891

Merged

This comment has been minimized.

Sign in to view

blt force-pushed the blt/antithesis_intake_port branch from 825a824 to 9cb8d2d Compare June 18, 2026 21:34

blt force-pushed the blt/move_antithesis_deploy_to_scenarios_general branch from 8eb47bd to f4e1e05 Compare June 18, 2026 21:34

blt changed the title ~~Move antithesis/deploy to scenarios/general~~ enhancement(antithesis): Move antithesis/deploy to scenarios/general Jun 18, 2026

blt force-pushed the blt/move_antithesis_deploy_to_scenarios_general branch from f4e1e05 to 40344fa Compare June 18, 2026 22:58

blt mentioned this pull request Jun 18, 2026

chore(antithesis): split intake HTTP modules #1892

Merged

4 tasks

blt force-pushed the blt/move_antithesis_deploy_to_scenarios_general branch from 40344fa to 57d7eed Compare June 18, 2026 23:27

blt force-pushed the blt/antithesis_intake_port branch from 9cb8d2d to 807b378 Compare June 18, 2026 23:27

blt mentioned this pull request Jun 18, 2026

enhancement(antithesis): accept Datadog intake endpoints #1893

Merged

4 tasks

blt marked this pull request as ready for review June 22, 2026 17:44

blt requested review from a team as code owners June 22, 2026 17:44

Copilot AI review requested due to automatic review settings June 22, 2026 17:44

Copilot started reviewing on behalf of blt June 22, 2026 17:45 View session

Copilot AI reviewed Jun 22, 2026

View reviewed changes

blt force-pushed the blt/move_antithesis_deploy_to_scenarios_general branch from 57d7eed to 78a3787 Compare June 22, 2026 18:48

blt force-pushed the blt/antithesis_intake_port branch 2 times, most recently from 65c7887 to aa4004f Compare June 22, 2026 19:05

Copilot AI review requested due to automatic review settings June 22, 2026 19:05

blt force-pushed the blt/move_antithesis_deploy_to_scenarios_general branch from 78a3787 to 6b0eb35 Compare June 22, 2026 19:05

Copilot started reviewing on behalf of blt June 22, 2026 19:05 View session

Copilot AI reviewed Jun 22, 2026

View reviewed changes

blt force-pushed the blt/move_antithesis_deploy_to_scenarios_general branch 2 times, most recently from ddf3339 to cfa40e8 Compare June 22, 2026 23:27

Copilot AI review requested due to automatic review settings June 22, 2026 23:27

blt force-pushed the blt/antithesis_intake_port branch from 2fcdd8d to 9cd0107 Compare June 22, 2026 23:27

Copilot started reviewing on behalf of blt June 22, 2026 23:28 View session

Copilot AI reviewed Jun 22, 2026

View reviewed changes

blt force-pushed the blt/antithesis_intake_port branch from 9cd0107 to c3bf9de Compare June 23, 2026 16:24

blt force-pushed the blt/move_antithesis_deploy_to_scenarios_general branch from cfa40e8 to 72cca97 Compare June 23, 2026 16:24

blt force-pushed the blt/antithesis_intake_port branch from c3bf9de to a7e5cda Compare June 23, 2026 17:07

Copilot AI review requested due to automatic review settings June 23, 2026 17:07

blt force-pushed the blt/move_antithesis_deploy_to_scenarios_general branch from 72cca97 to ec7db94 Compare June 23, 2026 17:07

Copilot started reviewing on behalf of blt June 23, 2026 17:07 View session

Copilot AI reviewed Jun 23, 2026

View reviewed changes

blt force-pushed the blt/move_antithesis_deploy_to_scenarios_general branch from ec7db94 to f6501ff Compare June 23, 2026 18:53

blt force-pushed the blt/antithesis_intake_port branch from a7e5cda to e53275f Compare June 23, 2026 18:53

blt force-pushed the blt/move_antithesis_deploy_to_scenarios_general branch from f6501ff to cb84121 Compare June 23, 2026 19:07

Copilot AI review requested due to automatic review settings June 23, 2026 19:07

Copilot started reviewing on behalf of blt June 23, 2026 19:08 View session

Copilot AI reviewed Jun 23, 2026

View reviewed changes

Base automatically changed from blt/antithesis_intake_port to main June 23, 2026 20:12

Move antithesis/deploy to scenarios/general

b43c958

blt force-pushed the blt/move_antithesis_deploy_to_scenarios_general branch from cb84121 to b43c958 Compare June 23, 2026 20:16

lucastemb approved these changes Jun 25, 2026

View reviewed changes

blt merged commit 2b0cad1 into main Jun 25, 2026
82 of 83 checks passed

blt deleted the blt/move_antithesis_deploy_to_scenarios_general branch June 25, 2026 17:54

Navigation Menu

Uh oh!

enhancement(antithesis): Move antithesis/deploy to scenarios/general - #1890

enhancement(antithesis): Move antithesis/deploy to scenarios/general#1890
blt merged 1 commit into
mainfrom
blt/move_antithesis_deploy_to_scenarios_general

blt commented Jun 18, 2026 •

edited

Loading

Uh oh!

blt commented Jun 18, 2026 •

edited

Loading

Uh oh!

This comment has been minimized.

pr-commenter Bot commented Jun 18, 2026 •

edited

Loading

Uh oh!

pr-commenter Bot commented Jun 18, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

blt commented Jun 25, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

blt commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Change Type

How did you test this PR?

References

Uh oh!

blt commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

pr-commenter Bot commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Binary Size Analysis (Agent Data Plane)

✅ Binary size difference within threshold

Uh oh!

pr-commenter Bot commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Regression Detector (Agent Data Plane)

Optimization Goals: ✅ No significant changes detected

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

blt commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

blt commented Jun 18, 2026 •

edited

Loading

blt commented Jun 18, 2026 •

edited

Loading

pr-commenter Bot commented Jun 18, 2026 •

edited

Loading

pr-commenter Bot commented Jun 18, 2026 •

edited

Loading

blt commented Jun 25, 2026 •

edited

Loading