enhancement(antithesis): Introduce rig intake API - #1826
Merged
Conversation
This was referenced Jun 5, 2026
dd-octo-sts
Bot
added
the
area/test
This was referenced Jun 5, 2026
Contributor
Author
4 tasks
This comment has been minimized.
This comment has been minimized.
Binary Size Analysis (Agent Data Plane)Baseline: 389eb6b · Comparison: e53275f · diff ✅ Binary size difference within thresholdChanges by Module
Detailed Symbol Changes |
Regression Detector (Agent Data Plane)Run ID: Optimization Goals: ✅ No significant changes detectedFine details of change detection per experiment (35)Experiments configured
Bounds Checks: ❌ Failed (5)
ExplanationA change is flagged as a regression when |Δ mean %| > 5.00% in the regressing direction for its optimization goal AND SMP marks the experiment as a regression ( |
blt
force-pushed
the
blt/antithesis_intake_port
branch
from
June 15, 2026 22:33
a6287d2 to
2c2f617
Compare
blt
force-pushed
the
blt/antithesis-workload-sampling
branch
2 times, most recently
from
June 15, 2026 22:44
323267a to
8c7b55d
Compare
blt
force-pushed
the
blt/antithesis_intake_port
branch
2 times, most recently
from
June 16, 2026 22:37
fd1387d to
825a824
Compare
This was referenced Jun 18, 2026
blt
force-pushed
the
blt/antithesis_intake_port
branch
from
June 18, 2026 21:34
825a824 to
9cb8d2d
Compare
blt
force-pushed
the
blt/antithesis-workload-sampling
branch
from
June 18, 2026 21:34
8c7b55d to
084d401
Compare
blt
changed the title
blt
marked this pull request as ready for review
June 18, 2026 21:40
There was a problem hiding this comment.
Pull request overview
This PR adds a dedicated antithesis-intake crate for Antithesis harness runs, implementing an /api/v2/series HTTP intake that asserts Pyld01–Pyld22 payload properties via the Antithesis SDK, and wires it into the Antithesis deploy images (replacing the shared correctness datadog-intake in that context).
Changes:
- Introduces the new
test/antithesis/intakecrate and binary (antithesis-intake) with an Axum router and a property-assertion pipeline for/api/v2/series. - Updates Antithesis deploy Dockerfile/compose to build and run
antithesis-intake(and removesfinally_verify_deliveryfrom the image build/copy path). - Adds/updates documentation describing the new intake and its asserted properties.
Reviewed changes
Copilot reviewed 20 out of 21 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| test/antithesis/scratchbook/w-property-intake.md | New scratchbook doc describing the W/Pyld property intake behavior. |
| test/antithesis/intake/src/properties/payload/series.rs | Implements MetricSeries-level Pyld checks (name, type, tags, origin, point-count). |
| test/antithesis/intake/src/properties/payload/resource.rs | Implements resource-level Pyld checks (host resource resolution, resource count, hostname length). |
| test/antithesis/intake/src/properties/payload/point.rs | Implements MetricPoint-level Pyld checks (NaN values, future timestamp bound). |
| test/antithesis/intake/src/properties/payload/metric_payload.rs | Implements payload-level Pyld checks (decode success, total point count). |
| test/antithesis/intake/src/properties/payload/envelope.rs | Implements envelope/header Pyld checks (content-type, content-encoding, API key presence). |
| test/antithesis/intake/src/properties/payload/constants.rs | Defines shared spec-derived constants for payload checks. |
| test/antithesis/intake/src/properties/payload/bytes.rs | Implements size/Content-Length Pyld checks. |
| test/antithesis/intake/src/properties/payload.rs | Defines payload property modules. |
| test/antithesis/intake/src/properties.rs | Top-level properties module wiring for the intake. |
| test/antithesis/intake/src/lib.rs | Crate root for antithesis-intake, including lint policy and module exports. |
| test/antithesis/intake/src/intake.rs | /api/v2/series handler and evaluation pipeline. |
| test/antithesis/intake/src/http.rs | Axum router construction and measurement middleware for wire/decompressed sizes. |
| test/antithesis/intake/src/bin/intake.rs | Binary entrypoint (CLI/env config, logging, graceful shutdown). |
| test/antithesis/intake/README.md | Spec-style documentation for Pyld01–Pyld22 properties. |
| test/antithesis/intake/Cargo.toml | New crate manifest and dependencies for antithesis-intake. |
| test/antithesis/harness/src/bin/finally_verify_delivery.rs | Removed (previous /metrics/dump polling liveness check). |
| test/antithesis/deploy/Dockerfile | Builds/runs antithesis-intake in the Antithesis intake image; removes finally_verify_delivery. |
| test/antithesis/deploy/docker-compose.yaml | Updates comments to reflect antithesis-intake. |
| Cargo.toml | Adds test/antithesis/intake to the workspace members. |
| Cargo.lock | Adds the antithesis-intake package entry. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9cb8d2dd37
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
4 tasks
blt
force-pushed
the
blt/antithesis_intake_port
branch
from
June 18, 2026 23:27
9cb8d2d to
807b378
Compare
4 tasks
blt
force-pushed
the
blt/antithesis-workload-sampling
branch
from
June 22, 2026 19:05
07d1980 to
ecdc5df
Compare
4 tasks
blt
force-pushed
the
blt/antithesis-workload-sampling
branch
from
June 22, 2026 20:58
ecdc5df to
eb2197b
Compare
blt
force-pushed
the
blt/antithesis_intake_port
branch
from
June 22, 2026 20:58
aa4004f to
2fcdd8d
Compare
blt
force-pushed
the
blt/antithesis-workload-sampling
branch
4 times, most recently
from
June 22, 2026 23:27
02c9828 to
e2f4b11
Compare
blt
force-pushed
the
blt/antithesis_intake_port
branch
from
June 22, 2026 23:27
2fcdd8d to
9cd0107
Compare
An error occurred while trying to automatically change base from
blt/antithesis-workload-sampling
to
main
June 23, 2026 12:33
tobz
approved these changes
Jun 23, 2026
tobz
left a comment
tobz
left a comment
Member
There was a problem hiding this comment.
Most of this looks reasonable to me, but I leave it to you to address the clanker feedback and merge conflicts before merging. 👍🏻
blt
force-pushed
the
blt/antithesis_intake_port
branch
2 times, most recently
from
June 23, 2026 17:07
c3bf9de to
a7e5cda
Compare
This commit introduces an intake API for antithesis tests. It's a new implementation compared to the pre-existing intake in the project as this intake has different concerns. However, my hope is to eventually merge the two together once this one is done baking, or supplant the other depending on where we get to.
blt
force-pushed
the
blt/antithesis_intake_port
branch
from
June 23, 2026 18:53
a7e5cda to
e53275f
Compare
dd-octo-sts Bot
pushed a commit
that referenced
this pull request
Jun 23, 2026
## Summary This commit introduces an intake API for antithesis tests. It's a new implementation compared to the pre-existing intake in the project as this intake has different concerns. It will rapidly diverge from the other intake, being focused on allowing driver and check claims when running under Antithesis. ## Change Type - [ ] Bug fix - [ ] New feature - [x] Non-functional (chore, refactoring, docs) - [ ] Performance 9c1abde
tobz
pushed a commit
that referenced
this pull request
Jun 30, 2026
This commit introduces an intake API for antithesis tests. It's a new implementation compared to the pre-existing intake in the project as this intake has different concerns. It will rapidly diverge from the other intake, being focused on allowing driver and check claims when running under Antithesis. - [ ] Bug fix - [ ] New feature - [x] Non-functional (chore, refactoring, docs) - [ ] Performance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This commit introduces an intake API for antithesis tests. It's a new implementation compared to the pre-existing intake in the project as this intake has different concerns. It will rapidly diverge from the other intake, being focused on allowing driver and check claims when running under Antithesis.
Change Type
How did you test this PR?
References