chore(antithesis): split intake HTTP modules - #1892
Conversation
This comment has been minimized.
This comment has been minimized.
Binary Size Analysis (Agent Data Plane)Baseline: 2b0cad1 · Comparison: 49d9bc6 · diff ✅ Binary size difference within thresholdChanges by Module
Detailed Symbol Changes |
Regression Detector (Agent Data Plane)Run ID: Optimization Goals: ✅ No significant changes detectedFine details of change detection per experiment (35)Experiments configured
Bounds Checks: ✅ Passed (5)
ExplanationA change is flagged as a regression when |Δ mean %| > 5.00% in the regressing direction for its optimization goal AND SMP marks the experiment as a regression ( |
03f2c03 to
cb55618
Compare
40344fa to
57d7eed
Compare
57d7eed to
78a3787
Compare
cb55618 to
68aea10
Compare
78a3787 to
6b0eb35
Compare
68aea10 to
43b6ef9
Compare
6b0eb35 to
ddf3339
Compare
43b6ef9 to
ccd88a8
Compare
ddf3339 to
cfa40e8
Compare
7fe8277 to
7e581a6
Compare
72cca97 to
ec7db94
Compare
7e581a6 to
33412fb
Compare
There was a problem hiding this comment.
Pull request overview
Refactors the Antithesis intake HTTP surface to split Datadog-compatible routes and request-measurement middleware into dedicated submodules, as prep work for adding additional scenario/rig-specific HTTP routes.
Changes:
- Extracted request measurement logic into
http/middleware.rsand updated imports accordingly. - Introduced
http/datadog.rs(andhttp/datadog/metrics.rs) to house Datadog-compatible routes/handlers. - Simplified
http.rsto focus on composing the top-level router.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/antithesis/intake/src/lib.rs | Removes the old intake module entry point as handlers move under http/. |
| test/antithesis/intake/src/http.rs | Router composition now delegates to protocol submodules and middleware. |
| test/antithesis/intake/src/http/middleware.rs | New module containing measurement middleware and request extensions. |
| test/antithesis/intake/src/http/datadog.rs | New module defining Datadog-compatible intake routes. |
| test/antithesis/intake/src/http/datadog/metrics.rs | Houses the /api/v2/series handler and validation pipeline. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
33412fb to
8bf7fa6
Compare
ec7db94 to
f6501ff
Compare
8bf7fa6 to
6ec313e
Compare
f6501ff to
cb84121
Compare
6ec313e to
78229ab
Compare
78229ab to
fdd089b
Compare
cb84121 to
b43c958
Compare
fdd089b to
f1148f7
Compare
f1148f7 to
49d9bc6
Compare
## Summary <!-- Please provide a brief summary about what this PR does. This should help the reviewers give feedback faster and with higher quality. --> This commit is prep work for up-stack differential equivalence work. I will be adding more HTTP routes for the scenario rig to hook into, distinct from the routes that are used by ADP in its normal operation. I found as I was working on that code a desire for tidy organization, the root of which is present here. ## Change Type - [ ] Bug fix - [ ] New feature - [x] Non-functional (chore, refactoring, docs) - [ ] Performance ## How did you test this PR? <!-- Please how you tested these changes here --> ## References <!-- Please list any issues closed by this PR. --> <!-- - Closes: <issue link> --> <!-- Any other issues or PRs relevant to this PR? Feel free to list them here. --> d95a996
<!-- Please provide a brief summary about what this PR does. This should help the reviewers give feedback faster and with higher quality. --> This commit is prep work for up-stack differential equivalence work. I will be adding more HTTP routes for the scenario rig to hook into, distinct from the routes that are used by ADP in its normal operation. I found as I was working on that code a desire for tidy organization, the root of which is present here. - [ ] Bug fix - [ ] New feature - [x] Non-functional (chore, refactoring, docs) - [ ] Performance <!-- Please how you tested these changes here --> <!-- Please list any issues closed by this PR. --> <!-- - Closes: <issue link> --> <!-- Any other issues or PRs relevant to this PR? Feel free to list them here. -->

Summary
This commit is prep work for up-stack differential equivalence work. I will be adding
more HTTP routes for the scenario rig to hook into, distinct from the routes that are
used by ADP in its normal operation. I found as I was working on that code a desire
for tidy organization, the root of which is present here.
Change Type
How did you test this PR?
References