Skip to content

Conversation

@slevis-lmwg
Copy link
Contributor

@slevis-lmwg slevis-lmwg commented Nov 27, 2025

Description of changes

Updated paths and file names for ctsm5.4.

Specific notes

CTSM Issues Fixed (include github issue #):
Does more work for #2851
Fixes #3495
Fixes #3642

Are answers expected to change (and if so in what way)?
The tests affected will change answers.

Testing TODOs

  • Check for ctsm_sci tests that match Will's ctsm5.4 simulations and add if not present
  • Run all tests

@slevis-lmwg slevis-lmwg self-assigned this Nov 27, 2025
@slevis-lmwg slevis-lmwg added the non-bfb Changes answers (incl. adding tests) label Nov 27, 2025
@slevis-lmwg slevis-lmwg changed the title Three user_nl_clm and two .cfg files with ctsm5.4 updates alpha-ctsm5.4.CMIP7.21.ctsm5.3.085: Three user_nl_clm and two .cfg files with ctsm5.4 updates Dec 1, 2025
@slevis-lmwg
Copy link
Contributor Author

Checking for ctsm_sci tests that cover the ctsm5.4 simulations listed in What's New.

@ekluzek let's look over these lists together:

ERI_D_Ld9.f10_f10_mg37.I1850Clm60BgcCrujra.derecho_gnu.clm-default
ERP_Ld9.f45_g37.I2000Clm60BgcCrujra.derecho_intel.clm-default
ERS_Ld3.f10_f10_mg37.I2000Clm60BgcCrujra.derecho_intel.clm-ciso_cwd_hr
SMS_Ld3_PS.f09_t232.I1850Clm60BgcCrujraNoAnthro.derecho_intel.clm-decStart1851_noinitial
SMS_Ld5.f09_t232.I1850Clm60BgcCrujra.derecho_intel.clm-default
SMS_Ld5.f19_g17.I1850Clm60BgcCrujra.derecho_intel.clm-default
RXCROPMATURITY_Lm61.f09_t232.IHistClm60BgcCropCrujra.derecho_intel.clm-cropMonthOutput
SMS_Ld5.f09_t232.IHistClm60BgcCropCrujra.derecho_intel.clm-default
SMS_Ld5.f19_g17.IHistClm60BgcCropCrujra.derecho_intel.clm-default
SMS_Ld5.hcru_hcru_mt13.IHistClm60BgcCropCrujra.derecho_intel.clm-default
SMS_Ln9.C96_C96_mt232.IHistClm60BgcCropCrujra.derecho_intel.clm-clm60cam7LndTuningMode

ERP_D_Ld10.f10_f10_mg37.I1850Clm60BgcCrop.derecho_intel.clm-ADspinup
SMS_D_Ld1.ne30pg3_t232.I1850Clm50BgcSpinup.derecho_intel.clm-cplhist
SMS_D_Ld1.ne30pg3_t232.I1850Clm50BgcSpinup.derecho_intel.clm-cplhist--clm-matrixcnOn
ERI_Ld9.f09_t232.I2000Clm60BgcCropCrujra.derecho_intel.clm-default
SMS_Lm1.ne30pg3_t232.I1850Clm60BgcCropCrujraG.derecho_intel.clm-clm60cam7LndTuningMode
SMS_Ln9.ne0ARCTICGRISne30x8_ne0ARCTICGRISne30x8_mt12.I1850Clm60BgcCropCrujra.derecho_intel.clm-clm60cam7LndTuningMode--clm-nofireemis

SMS_Ly3.f10_f10_mt232.IHistClm60BgcCropCrujra.derecho_intel.clm-ciso_cmip7_monthly_2013Start
SMS_Ly3.f10_f10_mt232.IHistClm60BgcCropCrujra.derecho_intel.clm-ciso_monthly_2013Start
SMS.ne30pg3_ne30pg3_mg17.IHistClm60SpCrujra.derecho_intel.clm-clm60cam7LndTuningMode--clm-nofireemis

ERP_D_Ld5.ne30pg3_t232.IHistClm60Sp.derecho_intel.clm-default--clm-nofireemis
SMS_Ld5.f09_t232.IHistClm60SpCrujra.derecho_intel.clm-default--clm-nofireemis

SMS_D_Ld3_PS.f09_t232.I1850Clm60SpCrujraNoAnthro.derecho_intel.clm-decStart1851_noinitial--clm-nofireemis

Introduce WhatsNewInCTSM5.4.md and update other documentation: PR ESCOMP#3364
@slevis-lmwg
Copy link
Contributor Author

slevis-lmwg commented Dec 2, 2025

Automatic python tests are failing but
PASS ./run_ctsm_py_tests -u
PASS ./run_ctsm_py_tests -s

@slevis-lmwg
Copy link
Contributor Author

Check why the .cfg files need updating now, when I thought I updated them to run make all_subset.

Copy link
Collaborator

@ekluzek ekluzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We went over this together. And it looks good to me. The one question that @slevis-lmwg already noted was that we want to make sure that the files created from subset_data are correct and the updates to the config files weren't needed for them.

@slevis-lmwg
Copy link
Contributor Author

Check why the .cfg files need updating now, when I thought I updated them to run make all_subset.

I have confirmed that there are two subset_data*cfg files used in testing (updated in this PR: default_data_gswp3.cfg and default_data.cfg in python/ctsm/test/testinputs) and two not used in testing (updated before I generated the ctsm5.4 datasets: default_data_2000.cfg and default_data_1850.cfg in tools/site_and_regional). So the datasets are fine, and I can merge this PR.

@slevis-lmwg
Copy link
Contributor Author

This PR is followed by #3638 which has no code changes planned. Instead of repeating all the tests twice, I will merge this PR (tag listed in the title), and then I will submit full ctsm5.4 testing from #3638.

@slevis-lmwg slevis-lmwg merged commit 673574b into ESCOMP:alpha-ctsm5.4.CMIP7 Dec 2, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this to Done (non release/external) in CTSM: Upcoming tags Dec 3, 2025
@slevis-lmwg slevis-lmwg moved this from Done (non release/external) to release/externals tags done in CTSM: Upcoming tags Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

non-bfb Changes answers (incl. adding tests)

Projects

Status: release/externals tags done

Development

Successfully merging this pull request may close these issues.

2 participants