-
Notifications
You must be signed in to change notification settings - Fork 341
alpha-ctsm5.4.CMIP7.21.ctsm5.3.085: Three user_nl_clm and two .cfg files with ctsm5.4 updates #3637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
alpha-ctsm5.4.CMIP7.21.ctsm5.3.085: Three user_nl_clm and two .cfg files with ctsm5.4 updates #3637
Conversation
|
Checking for ctsm_sci tests that cover the ctsm5.4 simulations listed in What's New. @ekluzek let's look over these lists together:
|
Introduce WhatsNewInCTSM5.4.md and update other documentation: PR ESCOMP#3364
|
Automatic python tests are failing but |
|
Check why the .cfg files need updating now, when I thought I updated them to run |
ekluzek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We went over this together. And it looks good to me. The one question that @slevis-lmwg already noted was that we want to make sure that the files created from subset_data are correct and the updates to the config files weren't needed for them.
I have confirmed that there are two subset_data*cfg files used in testing (updated in this PR: default_data_gswp3.cfg and default_data.cfg in |
Description of changes
Updated paths and file names for ctsm5.4.
Specific notes
CTSM Issues Fixed (include github issue #):
Does more work for #2851
Fixes #3495
Fixes #3642
Are answers expected to change (and if so in what way)?
The tests affected will change answers.
Testing TODOs