Skip to content

Conversation

@matthewelwell
Copy link
Contributor

Fixes an issue using semver based segments in local evaluation mode. The following error would occur:

Unhandled exception. System.IO.FileNotFoundException: Could not load file or assembly 'Semver, Version=2.1.0.0, Culture=neutral, PublicKeyToken=null'. The system cannot find the file specified.

This is seemingly caused by the fact that we're using ProjectReference to reference the Engine project which isn't including the subsequent PackageReferences in that project when building the FlagsmithClient project.

A more long term solution is likely to dotnet pack the Flagsmith.Engine project and add it as a PackageReference in the FlagsmithClient project.

Note that we also bump to the latest minor version as part of this PR.

@matthewelwell matthewelwell requested review from a team and zachaysan and removed request for a team January 14, 2025 17:29
@matthewelwell matthewelwell removed the request for review from zachaysan January 14, 2025 17:36
@matthewelwell matthewelwell force-pushed the fix/missing-semver-dependency branch from ec8908e to cd314e4 Compare January 14, 2025 18:00
@matthewelwell
Copy link
Contributor Author

matthewelwell commented Jan 14, 2025

So, my understanding of the workflow issues I'm seeing in this PR is that something has changed in the Github runner which means that the version we are referencing in global.json no longer exists on the runners. You can see in the following screenshot that previous runs of this workflow have passed, but not as we expect - they are just running the tests against 7.0.43 instead of the version configured in the matrix.

image



We probably have a few options to resolve this:

  1. Get rid of matrix testing and just test on a single version (this is probably a bad idea)
  2. Remove global.json (although that is now inexplicably causing an issue with the EngineTest project, see here)
  3. Maybe something else?

@matthewelwell matthewelwell merged commit 8f41ebb into main Jan 14, 2025
10 checks passed
@matthewelwell matthewelwell deleted the fix/missing-semver-dependency branch January 14, 2025 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants