Conversation
cmdcolin
force-pushed
the
fix_phase2
branch
2 times, most recently
from
46e4ffc to
9ed9ac2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This might be from ancient NCList data from jbrowse 1, i think it is not even the case that all jbrowse 1 data has this issue, but having string phase causes problems with jbrowse for when it infers the protein sequence on gene glyphs and feature details. rather than making hacky fixes for this from jbrowse 2 side of things, this fixes it in @gmod/nclist itself here