Merged
Conversation
English was merged in ManageIQ#23665
Fixes broken test: placeholders translations preserve placeholders in strings
Manually fix based on change in: ManageIQ#23736
Fryguy
reviewed
Mar 4, 2026
|
|
||
| msgid "MiqServer|Capabilities" | ||
| msgstr "MiqServer|Capabilities" | ||
|
|
Member
There was a problem hiding this comment.
Curious they didn't translate this.
Member
Author
There was a problem hiding this comment.
haha, yeah. I don't know. Their tooling is continually breaking things, see second commit... I don't know if it's an oversight or thinking those are proper nouns to not get translated.
Member
|
Checked commits jrafanie/manageiq@d7f8a52~...635905f with ruby 3.3.10, rubocop 1.56.3, haml-lint 0.69.0, and yamllint |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates from translators based on March 2nd English strings
English was merged in Update English Translations #23665
Fix invalid placeholders %{...}
Fixes broken test: placeholders translations preserve placeholders in strings
Fix extra space in menu name
Manually fix based on change in:
Remove extra space from cluster memory menu name #23736