Skip to content

fix: Use diffcalc for star rating in /relax top #1003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaxOhn merged 3 commits into from
Apr 12, 2025
+3 −9
Merged

fix: Use diffcalc for star rating in /relax top #1003

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
509aaa9
Use diffcalc for star rating in /relax top
Chiffario Apr 11, 2025
c1b22d6
Remove star rating sort :(
Chiffario Apr 12, 2025
e43a359
Reuse PerformanceAttributes
Chiffario Apr 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions bathbot/src/active/impls/relax/top.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,9 @@ impl RelaxTopPagination {
};

let mods = &score.mods;
let max_attrs = Context::pp(map).mods(mods.clone()).performance().await;
let mut pp_manager = Context::pp(map).mods(mods.clone());
let stars = pp_manager.difficulty().await.stars();
let max_attrs = pp_manager.performance().await;
Comment thread
MaxOhn marked this conversation as resolved.
Outdated

// NOTE: Make generic versions of formatting functions later on
// this is ugly
Expand All @@ -141,7 +143,7 @@ impl RelaxTopPagination {
map_id = score.beatmap_id,
mods = ModsFormatter::new(mods),
pp = PpFormatter::new(score_pp, Some(max_pp)),
stars = score.beatmap.star_rating_normal,
stars = stars,
Comment thread
MaxOhn marked this conversation as resolved.
Outdated
acc = round(score.accuracy),
score = WithComma::new(score.total_score),
combo = ComboFormatter::new(score.combo, Some(max_combo)),
Expand Down