Skip to content

feat: slightly better serializer for unit actions and state, added attack action too #6834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Apr 14, 2025

Merge branch 'master' into feat/dataset-loger-improvements

93e2c91
Select commit
Loading
Failed to load commit list.
Merged

feat: slightly better serializer for unit actions and state, added attack action too #6834

Merge branch 'master' into feat/dataset-loger-improvements
93e2c91
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 14, 2025 in 0s

30.12% (+0.04%) compared to e60f4a6

View this Pull Request on Codecov

30.12% (+0.04%) compared to e60f4a6

Details

Codecov Report

Attention: Patch coverage is 41.47399% with 405 lines in your changes missing coverage. Please review.

Project coverage is 30.12%. Comparing base (e60f4a6) to head (93e2c91).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
megamek/src/megamek/ai/dataset/UnitAttack.java 25.71% 78 Missing ⚠️
megamek/src/megamek/ai/dataset/UnitAction.java 35.92% 66 Missing ⚠️
megamek/src/megamek/ai/dataset/UnitState.java 38.46% 56 Missing ⚠️
megamek/src/megamek/ai/dataset/GameData.java 15.90% 37 Missing ⚠️
...k/src/megamek/ai/dataset/EntityDataSerializer.java 28.57% 35 Missing ⚠️
megamek/src/megamek/common/GameDatasetLogger.java 19.35% 25 Missing ⚠️
...ek/src/megamek/ai/dataset/BoardDataSerializer.java 8.00% 23 Missing ⚠️
megamek/src/megamek/ai/dataset/BoardData.java 19.23% 21 Missing ⚠️
...mek/src/megamek/ai/dataset/GameDataSerializer.java 12.50% 21 Missing ⚠️
megamek/src/megamek/ai/dataset/EntityDataMap.java 0.00% 17 Missing ⚠️
... and 4 more
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #6834      +/-   ##
============================================
+ Coverage     30.07%   30.12%   +0.04%     
+ Complexity    15620    15611       -9     
============================================
  Files          2875     2884       +9     
  Lines        282748   283107     +359     
  Branches      49302    49296       -6     
============================================
+ Hits          85047    85279     +232     
- Misses       192135   192275     +140     
+ Partials       5566     5553      -13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov