-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Port Validation (Sentry) #6857
Open
IllianiBird
wants to merge
4
commits into
MegaMek:master
Choose a base branch
from
IllianiBird:fixedPortValidation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed port parsing to use MathUtility and return the Default Port in the event a malformed port is entered by user - Added missing error string for port validation
… utility method. - This prevents invalid ports outside the range of `MMConstants.MIN_PORT` and `MMConstants.MAX_PORT`.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6857 +/- ##
============================================
- Coverage 30.05% 30.05% -0.01%
+ Complexity 15581 15579 -2
============================================
Files 2875 2875
Lines 282748 282748
Branches 49302 49302
============================================
- Hits 84983 84982 -1
- Misses 192210 192213 +3
+ Partials 5555 5553 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rjhancock
approved these changes
Apr 9, 2025
rjhancock
approved these changes
Apr 11, 2025
megamek/src/megamek/client/ui/swing/gameConnectionDialogs/AbstractGameConnectionDialog.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MathUtility
and return the Default Port in the event a malformed port is entered by userclamp
utility method. This prevents invalid ports outside the range ofMMConstants.MIN_PORT
andMMConstants.MAX_PORT
.Fix Sentry Report