Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Port Validation (Sentry) #6857

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

IllianiBird
Copy link
Collaborator

@IllianiBird IllianiBird commented Apr 9, 2025

  • Fixed port parsing to use MathUtility and return the Default Port in the event a malformed port is entered by user
  • Ensured the port value is clamped to valid bounds using the clamp utility method. This prevents invalid ports outside the range of MMConstants.MIN_PORT and MMConstants.MAX_PORT.
  • Added missing error string for port validation

Fix Sentry Report

- Fixed port parsing to use MathUtility and return the Default Port in the event a malformed port is entered by user
- Added missing error string for port validation
@IllianiBird IllianiBird added Bug Severity: Low Issues described as low severity as per the new issue form labels Apr 9, 2025
@IllianiBird IllianiBird self-assigned this Apr 9, 2025
… utility method.

- This prevents invalid ports outside the range of `MMConstants.MIN_PORT` and `MMConstants.MAX_PORT`.
Copy link

codecov bot commented Apr 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 30.05%. Comparing base (eb59e2d) to head (7762e8e).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...onnectionDialogs/AbstractGameConnectionDialog.java 0.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6857      +/-   ##
============================================
- Coverage     30.05%   30.05%   -0.01%     
+ Complexity    15581    15579       -2     
============================================
  Files          2875     2875              
  Lines        282748   282748              
  Branches      49302    49302              
============================================
- Hits          84983    84982       -1     
- Misses       192210   192213       +3     
+ Partials       5555     5553       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Severity: Low Issues described as low severity as per the new issue form
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants