Added Heroic and Legendary Skill Levels #6864
Draft
+35
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced new skill levels: Heroic and Legendary, with corresponding experience values and level definitions. - Updated `LevelSorter` to handle skill level comparisons using the new `SkillLevel` enums. - Added logic for parsing, getting, and setting Heroic and Legendary levels in `SkillType`. - Modified XML serialization and deserialization to include Heroic and Legendary levels. - Adjusted color handling for Heroic and Legendary to reuse Elite color settings.
IllianiBird
added
the
Implementation of Missing Official Rule
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6864 +/- ##
============================================
- Coverage 30.06% 30.06% -0.01%
+ Complexity 15604 15595 -9
============================================
Files 2875 2875
Lines 282752 282750 -2
Branches 49309 49310 +1
============================================
- Hits 85016 84995 -21
- Misses 192173 192200 +27
+ Partials 5563 5555 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rjhancock
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dev Notes
This is the MegaMek portion of MegaMek/mekhq#6623