Fix #3111: Added Heroic and Legendary Skill Levels #6623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced new skill levels: Heroic and Legendary, with corresponding experience values and level definitions. - Updated `LevelSorter` to handle skill level comparisons using the new `SkillLevel` enums. - Added logic for parsing, getting, and setting Heroic and Legendary levels in `SkillType`. - Modified XML serialization and deserialization to include Heroic and Legendary levels. - Adjusted color handling for Heroic and Legendary to reuse Elite color settings.
IllianiBird
added
Personnel
…ELITE` to `EXP_LEGENDARY`).
|
Keeping this on draft as I don't think it should be included in 50.05 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6623 +/- ##
============================================
- Coverage 11.43% 11.42% -0.01%
- Complexity 6451 6454 +3
============================================
Files 1086 1086
Lines 139459 139532 +73
Branches 21571 21583 +12
============================================
- Hits 15948 15943 -5
- Misses 121914 121986 +72
- Partials 1597 1603 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LevelSorterto handle skill level comparisons using the newSkillLevelenums.SkillType.Fix #3111
Requirements
Requires MegaMek/megamek#6864
Dev Notes
So most of the work was already done and implemented, we just hadn't 'turned on' these skill levels. I checked with both new and existing campaigns and found no issues making these available.