Fix #6867: Excluded Infantry Attack From Edit Unit Damage Dialog #6868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Prevented `InfantryAttack` equipment types from being processed in the equipment loop within `UnitEditorDialog`. - Refactored variable names for better code clarity (e.g., `m` to `mounted`).
IllianiBird
added
Bug
Severity: Low
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6868 +/- ##
============================================
- Coverage 30.06% 30.05% -0.01%
+ Complexity 15604 15588 -16
============================================
Files 2875 2875
Lines 282752 282753 +1
Branches 49309 49304 -5
============================================
- Hits 85016 84989 -27
- Misses 192173 192214 +41
+ Partials 5563 5550 -13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rjhancock
reviewed
Apr 11, 2025
Comment on lines
-60
to
+72
| /* system crits */ | ||
| CheckCritPanel engineCrit; | ||
| /* system crits */ CheckCritPanel engineCrit; |
There was a problem hiding this comment.
This is a nitpick, replace the comment with a // and bring the variable down a level.
There was a problem hiding this comment.
We might need to look at why EC made this change, as it'll just be undone the moment I save
There was a problem hiding this comment.
Ah, ignore me, I missed the first part of your comment.
rjhancock
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InfantryAttackequipment types from being processed in the equipment loop withinUnitEditorDialog.mtomounted).Fix #6867
Dev Notes
I double-checked that infantry attacks, such as swarm and its' ilk, are the only attacks affected by this change.