Fix: MacOS and Linux users can now open the right-click popup contextual menu on force view #6978
+30
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l menu on force fiew
Scoppio
added
Bug
Accessibility
Scoppio
changed the title
There was a problem hiding this comment.
Pull Request Overview
This pull request ensures that the right-click popup contextual menu opens consistently across operating systems by handling mouse events differently on Mac/Linux versus Windows. In addition, it refines some TODO comment formatting and replaces console error printing with proper logging.
- Adjusted right-click event handling in ChatLounge.java to support OS-specific behavior.
- Updated TODO comment formatting in ChatLounge.java.
- Improved error handling and logging in SBFStatsDialog.java with a potential correction in stats panel initialization.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| megamek/src/megamek/client/ui/swing/lobby/ChatLounge.java | Updated mouse event handling and refined comments to trigger the popup on the correct mouse events. |
| megamek/src/megamek/client/ui/dialogs/SBFStatsDialog.java | Introduced MMLogger for error logging and modified the stats panel initialization, which may lead to instance field shadowing. |
Scoppio
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6978 +/- ##
=========================================
Coverage 30.32% 30.32%
- Complexity 15837 15840 +3
=========================================
Files 2888 2888
Lines 283253 283257 +4
Branches 49328 49329 +1
=========================================
+ Hits 85903 85908 +5
+ Misses 191748 191746 -2
- Partials 5602 5603 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does?
Mac and Linux apparently only consider a right mouse click being a popup trigger event on press, and windows considers only on release. This change makes sure that the popup will open on any OS.
Related issues