Skip to content

Fixed Aero Heat Sink Appearing in Parts Store Multiplie Times #6519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2025

Conversation

IllianiBird
Copy link
Collaborator

  • Removed duplicated calls to add AeroHeatSink objects to the parts list.

Fix #6302

Dev Notes

So this bug has been shuffling about since 2017, it seems. Basically, we were adding normal Aero Heat Sinks twice to the Parts Store. Whoops! Now we're not. #profit

- Removed duplicated calls to add `AeroHeatSink` objects to the parts list.
@IllianiBird IllianiBird added Bug GUI Severity: Low Issues described as low severity as per the new issue form labels Apr 1, 2025
@IllianiBird IllianiBird self-assigned this Apr 1, 2025
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.27%. Comparing base (dbec8a9) to head (9dbfb66).
Report is 12 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6519      +/-   ##
============================================
- Coverage     11.28%   11.27%   -0.01%     
+ Complexity     6323     6318       -5     
============================================
  Files          1080     1080              
  Lines        137528   137525       -3     
  Branches      21295    21295              
============================================
- Hits          15516    15505      -11     
- Misses       120463   120466       +3     
- Partials       1549     1554       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rjhancock rjhancock merged commit 216ee26 into MegaMek:master Apr 4, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug GUI Severity: Low Issues described as low severity as per the new issue form
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] Different part quality causes bugs
2 participants